Attachment 348540 Details for Bug 189170 – Patch

[patch] Patch

bug-189170-20180830134259.patch (text/plain), 1.36 KB, created by Olivia Barnett on 2018-08-30 13:42:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivia Barnett

Created: 2018-08-30 13:42:59 PDT

Size: 1.36 KB

patch

obsolete

>Subversion Revision: 235520
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6195ecd9dd004a84fb087d84fff33ac6bbf602fc..cae39cb97a1eebc7648702a79da11b6add50b9b0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-30  Olivia Barnett  <obarnett@apple.com>
>+
>+        REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
>+        https://bugs.webkit.org/show_bug.cgi?id=189170
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests; fixing a failing existing test.
>+
>+        * page/Navigator.cpp:
>+        (WebCore::Navigator::share):
>+        Added null check for frame.
>+
> 2018-08-30  Andy Estes  <aestes@apple.com>
> 
>         [Payment Request] Implement the PaymentMethodChangeEvent and PaymentMethodChangeEventInit interfaces
>diff --git a/Source/WebCore/page/Navigator.cpp b/Source/WebCore/page/Navigator.cpp
>index 2aef7a9cc5021e40c7195c882e400e339cfb348e..7569ca854ec6bb0993e5c3a7d0ee82419f52b3a3 100644
>--- a/Source/WebCore/page/Navigator.cpp
>+++ b/Source/WebCore/page/Navigator.cpp
>@@ -99,7 +99,7 @@ bool Navigator::onLine() const
> 
> void Navigator::share(ScriptExecutionContext& context, ShareData data, Ref<DeferredPromise>&& promise)
> {
>-    if (!m_frame->page()) {
>+    if (!m_frame || !m_frame->page()) {
>         promise->reject(TypeError);
>         return;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 189170: 348537 | 348540