Attachment 348499 Details for Bug 189155 – Patch

[patch] Patch

bug-189155-20180830085224.patch (text/plain), 1.69 KB, created by youenn fablet on 2018-08-30 08:52:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-08-30 08:52:25 PDT

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 235451
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8e1051868b1e0f18352ec16d9fd0c5fb4983eb31..ad73d70ec6d9666bb62fce396ddc2b871c75da91 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-30  Youenn Fablet  <youenn@apple.com>
>+
>+        fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
>+        https://bugs.webkit.org/show_bug.cgi?id=189155
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/mediastream/RTCPeerConnection-overloaded-operations.html:
>+        createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
>+        Make sure that these promises are handled.
>+
> 2018-08-29  Youenn Fablet  <youenn@apple.com>
> 
>         Add a runtime flag for WebRTC unified plan
>diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html b/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html
>index 0fd1bb2eacd3e7c4791d222a799b0fcb700c8ea4..5bbe91fae6f7d430556b2cb0c13889acc47f0e8f 100644
>--- a/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html
>+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html
>@@ -27,9 +27,11 @@
> 
>                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc)");
>                 shouldBeType("result", "Promise");
>+                result.then(() => { }, () => { });
> 
>                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc, {})");
>                 shouldBeType("result", "Promise");
>+                result.then(() => { }, () => { });
>             }
> 
>             // Test setLocal/RemoteDescription()

Actions: View | Formatted Diff | Diff

Attachments on bug 189155: 348499