WebKit Bugzilla
Attachment 348489 Details for
Bug 189149
: [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189149-20180830162609.patch (text/plain), 1.70 KB, created by
Yoshiaki Jitsukawa
on 2018-08-30 00:26:11 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yoshiaki Jitsukawa
Created:
2018-08-30 00:26:11 PDT
Size:
1.70 KB
patch
obsolete
>Subversion Revision: 235493 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 43ccc4a6797557a401b16590b34af368bc4f7f1e..3dccccd0d467dec2b571bf18a0cc965621cc069f 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2018-08-30 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com> >+ >+ [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members >+ https://bugs.webkit.org/show_bug.cgi?id=189149 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Reorder members to shrink the size of AttachmentInfo so that >+ we can attach more attachments. >+ >+ * Platform/IPC/unix/ConnectionUnix.cpp: >+ > 2018-08-29 Alex Christensen <achristensen@webkit.org> > > Revert some of r235398 >diff --git a/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp b/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp >index 3c46394e2e3d34752bbc66d1a55252abbc37085e..9c380046ddbaf45f82ed4d69f85ba2d93f6695a5 100644 >--- a/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp >+++ b/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp >@@ -59,7 +59,7 @@ > namespace IPC { > > static const size_t messageMaxSize = 4096; >-static const size_t attachmentMaxAmount = 255; >+static const size_t attachmentMaxAmount = 254; > > class AttachmentInfo { > WTF_MAKE_FAST_ALLOCATED; >@@ -86,10 +86,12 @@ public: > > private: > Attachment::Type m_type { Attachment::Uninitialized }; >- size_t m_size { 0 }; > bool m_isNull { false }; >+ size_t m_size { 0 }; > }; > >+static_assert(sizeof(MessageInfo) + sizeof(AttachmentInfo) * attachmentMaxAmount <= messageMaxSize, "messageMaxSize is too small."); >+ > void Connection::platformInitialize(Identifier identifier) > { > m_socketDescriptor = identifier;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189149
: 348489