Attachment 348488 Details for Bug 189148 – Patch

[patch] Patch

bug-189148-20180829235010.patch (text/plain), 1.55 KB, created by Sihui Liu on 2018-08-29 23:50:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-29 23:50:11 PDT

Size: 1.55 KB

patch

obsolete

>Subversion Revision: 235490
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3ad6772a8a07b5ea6819e7bb50bf6e7ba66efd99..850605727ed105ec1e65806d443d11d915d41fb5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-29  Sihui Liu  <sihui_liu@apple.com>
>+
>+        WKNavigation.ProcessCrashDuringCallback is failing on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=189148
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should not deference WebView or we may get WKErrorWebViewInvalidated error, because 
>+        WebView could be destroyed before Web Process termination is noticed.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
>+        (TEST):
>+
> 2018-08-29  Jer Noble  <jer.noble@apple.com>
> 
>         Unreviewed test gardening; NowPlayingTest API tests require High Sierra.
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm
>index 6bdd532664859c854cf44f2ca54e2535c93141b3..cd8bab8bb38a5aa7ee54473e14a92a11cc05ca58 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm
>@@ -275,8 +275,6 @@ TEST(WKNavigation, ProcessCrashDuringCallback)
>     // Simulate a crash, which should invalidate all pending callbacks.
>     [webView _killWebContentProcess];
> 
>-    webView = nullptr;
>-
>     TestWebKitAPI::Util::run(&calledAllCallbacks);
>     TestWebKitAPI::Util::sleep(0.5);
>     EXPECT_EQ(6U, callbackCount);

Actions: View | Formatted Diff | Diff

Attachments on bug 189148: 348488