Attachment 348478 Details for Bug 185965 – Patch

[patch] Patch

bug-185965-20180829204757.patch (text/plain), 2.94 KB, created by Wenson Hsieh on 2018-08-29 20:47:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-08-29 20:47:58 PDT

Size: 2.94 KB

patch

obsolete

>Subversion Revision: 235441
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 859445afa796f6f8c86b3b767f72c74557de4fd1..598e597d220f12966bd5724c3ed30566f3a17310 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-29  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] TestWebKitAPI.PasteImage tests are flaky failures
>+        https://bugs.webkit.org/show_bug.cgi?id=185965
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
>+        element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
>+        because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
>+        this by waiting for the "load" event (which is also done in some of the other tests in this file).
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
>+        (TEST):
>+
> 2018-08-28  Sihui Liu  <sihui_liu@apple.com>
> 
>         Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
>index 89bc05ae670dcbc5d45483fbe7afb95f8221f47c..01591b2c4d8626017ea22abaefe7343bc3c47533 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
>@@ -67,6 +67,7 @@ TEST(PasteImage, PasteGIFImage)
>     EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(gifItem.file).toString()"]);
> 
>     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(gifItem.file)"];
>+    [webView waitForMessage:@"loaded"];
>     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
>     EXPECT_WK_STREQ("400", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
> }
>@@ -89,6 +90,7 @@ TEST(PasteImage, PasteJPEGImage)
>     EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(jpegItem.file).toString()"]);
> 
>     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(jpegItem.file)"];
>+    [webView waitForMessage:@"loaded"];
>     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
>     EXPECT_WK_STREQ("600", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
> }
>@@ -111,6 +113,7 @@ TEST(PasteImage, PastePNGImage)
>     EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(pngItem.file).toString()"]);
> 
>     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(pngItem.file)"];
>+    [webView waitForMessage:@"loaded"];
>     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
>     EXPECT_WK_STREQ("200", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 185965: 348478 | 348545