Attachment 348446 Details for Bug 189117 – Patch

[patch] Patch

bug-189117-20180829162904.patch (text/plain), 2.09 KB, created by Aditya Keerthi on 2018-08-29 16:29:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aditya Keerthi

Created: 2018-08-29 16:29:05 PDT

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 235471
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index bf2a8bae103d8cb01315ad1a7889a54e455e8a61..89745ac631c8828847a668f4ff59b70b5df1c8c4 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-08-29  Aditya Keerthi  <akeerthi@apple.com>
>+
>+        [macOS] Color picker layout is broken if suggested colors are specified
>+        https://bugs.webkit.org/show_bug.cgi?id=189117
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        NSPopoverColorWell recently changed the size of its swatches. We need to update
>+        the width of the swatches we provide to match the width of the other swatches,
>+        in order to avoid breaking the layout.
>+
>+        While such a solution is not a good precedent, we do not have fully-functional SPI
>+        to customize the suggested colors. A FIXME has been added for this reason.
>+        However, even once we obtain SPI, we will need to find a way to support older
>+        clients, making conditional compilation a potential necessity.
>+
>+        * UIProcess/mac/WebColorPickerMac.mm:
>+
> 2018-08-28  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Use CMake's FindFreetype
>diff --git a/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm b/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
>index f7aa37250011500cfae0b44112f4ebc28b663fda..34a360b91ef93d3eb37cb231193396a340760b20 100644
>--- a/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
>+++ b/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
>@@ -44,9 +44,15 @@
> 
> static const size_t maxColorSuggestions = 12;
> static const CGFloat colorPickerMatrixNumColumns = 12.0;
>-static const CGFloat colorPickerMatrixSwatchWidth = 12.0;
> static const CGFloat colorPickerMatrixBorderWidth = 1.0;
> 
>+// FIXME: <rdar://problem/41173525> We should not have to track changes in NSPopoverColorWell's implementation.
>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
>+static const CGFloat colorPickerMatrixSwatchWidth = 13.0;
>+#else
>+static const CGFloat colorPickerMatrixSwatchWidth = 12.0;
>+#endif
>+
> @protocol WKPopoverColorWellDelegate <NSObject>
> - (void)didClosePopover;
> @end

Actions: View | Formatted Diff | Diff

Attachments on bug 189117: 348446