Attachment 348431 Details for Bug 187972 – Patch

[patch] Patch

bug-187972-20180829141747.patch (text/plain), 2.21 KB, created by Jer Noble on 2018-08-29 14:17:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-08-29 14:17:47 PDT

Size: 2.21 KB

patch

obsolete

>Subversion Revision: 235463
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 06b4965a128fbed8aa462558387be21b205695e9..1339187e75c59b1d9c16fc434412881f62033afd 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-29  Jer Noble  <jer.noble@apple.com>
>+
>+        REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=187972
>+        <rdar://problem/42667737>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Ensure that listeners are added in time to catch messages broadcast at them.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
>+        (TestWebKitAPI::TEST):
>+
> 2018-08-28  Jer Noble  <jer.noble@apple.com>
> 
>         Muted elements do not have their Now Playing status updated when unmuted.
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm
>index c6dc0090366eea2afa9f9b99ef4b8625c70aebb9..cf1fba65eedf90b051c63889f84f1cef5f4cedc9 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm
>@@ -333,7 +333,6 @@ TEST(VideoControlsManager, VideoControlsManagerAudioElementFollowingUserInteract
> 
>     [webView loadTestPageNamed:@"play-audio-on-click"];
>     [webView waitForPageToLoadWithAutoplayingVideos:0];
>-    [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
> 
>     [webView performAfterReceivingMessage:@"playing-first" action:^ {
>         [webView evaluateJavaScript:@"seekToEnd()" completionHandler:nil];
>@@ -343,6 +342,9 @@ TEST(VideoControlsManager, VideoControlsManagerAudioElementFollowingUserInteract
>     [webView performAfterReceivingMessage:@"playing-second" action:^ {
>         secondAudioPlaying = true;
>     }];
>+
>+    [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
>+
>     TestWebKitAPI::Util::run(&secondAudioPlaying);
>     while ([[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]]) {
>         if ([webView _hasActiveVideoForControlsManager] && [[webView controlledElementID] isEqualToString:@"second"])

Actions: View | Formatted Diff | Diff

Attachments on bug 187972: 348431