Attachment 348403 Details for Bug 189083 – Patch

[patch] Patch

bug-189083-20180829094334.patch (text/plain), 1.54 KB, created by Thomas Denney on 2018-08-29 09:43:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Denney

Created: 2018-08-29 09:43:35 PDT

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 235463
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6c746cfa1caeaf05b4aa96c3d5566a71f8be6383..d9b286863fbf8631252d739e3c50c0283e2cdb84 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-29  Thomas Denney  <tdenney@apple.com>
>+
>+        [WHLSL] Ensure that isLValue is copied by the rewriter
>+        https://bugs.webkit.org/show_bug.cgi?id=189083
>+
>+        The value of isLValue was not propagated when new TernaryExpressions are
>+        created in Rewriter.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebGPUShadingLanguageRI/Rewriter.js:
>+        (Rewriter.prototype.visitTernaryExpression):
>+
> 2018-08-29  David Kilzer  <ddkilzer@apple.com>
> 
>         Remove empty directories from from svn.webkit.org repository
>diff --git a/Tools/WebGPUShadingLanguageRI/Rewriter.js b/Tools/WebGPUShadingLanguageRI/Rewriter.js
>index 94d3a762e38fb921c584cbafff1f59478ebb791d..3c95020aa4d6c4bb093575ab40968a5cb54eb758 100644
>--- a/Tools/WebGPUShadingLanguageRI/Rewriter.js
>+++ b/Tools/WebGPUShadingLanguageRI/Rewriter.js
>@@ -167,7 +167,9 @@ class Rewriter {
> 
>     visitTernaryExpression(node)
>     {
>-        return new TernaryExpression(node.origin, node.predicate.visit(this), node.bodyExpression.visit(this), node.elseExpression.visit(this));
>+        let result = new TernaryExpression(node.origin, node.predicate.visit(this), node.bodyExpression.visit(this), node.elseExpression.visit(this));
>+        result.isLValue = node.isLValue;
>+        return result;
>     }
>     
>     _handlePropertyAccessExpression(result, node)

Actions: View | Formatted Diff | Diff

Attachments on bug 189083: 348403 | 348405