Attachment 348384 Details for Bug 189073 – Patch

[patch] Patch

bug-189073-20180828203652.patch (text/plain), 1.97 KB, created by youenn fablet on 2018-08-28 20:36:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-08-28 20:36:53 PDT

Size: 1.97 KB

patch

obsolete

>Subversion Revision: 235451
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1215dd9705167e56cdd9f8517d6f70957c63a9d1..c74c169a3474bbc2a1565b1ef38774e8e1e55f93 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-08-28  Youenn Fablet  <youenn@apple.com>
>+
>+        IDBDatabase should not return true to hasPendingActivity after being stopped
>+        https://bugs.webkit.org/show_bug.cgi?id=189073
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        There is a chance that IDBDatabase::hasPendingActivity returns true.
>+        The case that might happen is when stop() is called but there are still some active/being committed transactions.
>+        In that case, hasPendingActivity will return true until these transactions get finalized.
>+        While these transactions will probably be finalized at some point, it delays GC for no good reason.
>+        And we might want in a follow-up patch to assert that ActiveDOMObject are GC-able whenever their context is stopped.
>+        For that purpose, make sure hasPendingActivity returns false when context is stopped.
>+
>+        * Modules/indexeddb/IDBDatabase.cpp:
>+        (WebCore::IDBDatabase::hasPendingActivity const):
>+
> 2018-08-27  Youenn Fablet  <youenn@apple.com>
> 
>         Remove WebRTC legacy API implementation
>diff --git a/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp b/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
>index 3391855baee55d059784c920e9c2428b271b9245..258d89a5adabca588a19a48d978f6ee221f8de7e 100644
>--- a/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
>+++ b/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
>@@ -76,7 +76,7 @@ bool IDBDatabase::hasPendingActivity() const
> {
>     ASSERT(&originThread() == &Thread::current() || mayBeGCThread());
> 
>-    if (m_closedInServer)
>+    if (m_closedInServer || isContextStopped())
>         return false;
> 
>     if (!m_activeTransactions.isEmpty() || !m_committingTransactions.isEmpty() || !m_abortingTransactions.isEmpty())

Actions: View | Formatted Diff | Diff

Attachments on bug 189073: 348384