Attachment 348373 Details for Bug 189016 – Unflake test

[patch] Unflake test

bug-189016-20180828183818.patch (text/plain), 2.33 KB, created by youenn fablet on 2018-08-28 18:38:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-08-28 18:38:19 PDT

Size: 2.33 KB

patch

obsolete

>Subversion Revision: 235451
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index aebc9939977504dda94aea41fe1f2a51f266a9bc..7cb23e1bf6f8f7dfa66f0fcf7c674ed596246fc5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-28  Youenn Fablet  <youenn@apple.com>
>+
>+        WebKitMediaSession should be GC collectable when its document is being stopped
>+        https://bugs.webkit.org/show_bug.cgi?id=189016
>+        <rdar://problem/43804904>
>+
>+        Unreviewed.
>+        Increasing number of GC and checks to unflake tests on bots.
>+
>+        * http/tests/IndexedDB/collect-IDB-objects.https.html:
>+        * http/tests/media/clearkey/collect-webkit-media-session.html:
>+
> 2018-08-27  Youenn Fablet  <youenn@apple.com>
> 
>         Remove WebRTC legacy API implementation
>diff --git a/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html b/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html
>index 1142f26450f8fdee5ecd5acc2fc4829b92deca73..3c283de5dcc7e6fb0781f6a993c8e6972ba15412 100644
>--- a/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html
>+++ b/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html
>@@ -20,7 +20,7 @@ async function done()
>         const frameIdentifier = internals.documentIdentifier(iframe.contentDocument);
>         iframe.src = "non-existent-frame";
>         let counter = 0;
>-        while (++counter < 10) {
>+        while (++counter < 50) {
>             if (!internals.isDocumentAlive(frameIdentifier)) {
>                 resolveCallback();
>                 return;
>diff --git a/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html b/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html
>index 82975dd8b2d5c6641f48adfc488974921b9c85e4..515ea7735f3ee6cb2b53164d53706faeb41e7163 100644
>--- a/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html
>+++ b/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html
>@@ -20,7 +20,7 @@ async function done()
>         const frameIdentifier = internals.documentIdentifier(iframe.contentDocument);
>         iframe.src = "non-existent-frame";
>         let counter = 0;
>-        while (++counter < 10) {
>+        while (++counter < 50) {
>             if (!internals.isDocumentAlive(frameIdentifier)) {
>                 resolveCallback();
>                 return;

Actions: View | Formatted Diff | Diff

Attachments on bug 189016: 348220 | 348295 | 348373