WebKit Bugzilla
Attachment 348352 Details for
Bug 189062
: lldb-webkit: KeyError thrown for OptionSet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189062-20180828152935.patch (text/plain), 1.51 KB, created by
Daniel Bates
on 2018-08-28 15:29:36 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-08-28 15:29:36 PDT
Size:
1.51 KB
patch
obsolete
>Subversion Revision: 235381 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index ebc5ac0c3edd97339d8a5aec184455b65bb52d8e..262ba8b7c528d87ffb9e70f9d2eedcdf6ee7de93 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,17 @@ >+2018-08-28 Daniel Bates <dabates@apple.com> >+ >+ lldb-webkit: KeyError thrown for OptionSet >+ https://bugs.webkit.org/show_bug.cgi?id=189062 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ For some reason lldb(1) may not retrieve the enumerator names for an enum value >+ when it calls update() on the synthetic children provider. If this occurs then >+ bail out as we cannot compute what enumerators are in the set. >+ >+ * lldb/lldb_webkit.py: >+ (WTFOptionSetProvider.update): >+ > 2018-08-27 Keith Rollin <krollin@apple.com> > > Build system support for LTO >diff --git a/Tools/lldb/lldb_webkit.py b/Tools/lldb/lldb_webkit.py >index 83dced417c5f8aaf2ffc85328123469466b0e3a9..44d77bb5a76b930c5ddc786bc89f57aadf0f0d06 100644 >--- a/Tools/lldb/lldb_webkit.py >+++ b/Tools/lldb/lldb_webkit.py >@@ -616,6 +616,8 @@ class WTFOptionSetProvider: > > template_argument_sbType = self.valobj.GetType().GetTemplateArgumentType(0) > enumerator_value_to_name_map = {sbTypeEnumMember.GetValueAsUnsigned(): sbTypeEnumMember.GetName() for sbTypeEnumMember in template_argument_sbType.get_enum_members_array()} >+ if not enumerator_value_to_name_map: >+ return > > # Iterate from least significant bit to most significant bit. > elements = []
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189062
: 348352