Attachment 348335 Details for Bug 189056 – PATCH

[patch] PATCH

189056.dif (text/plain), 1.46 KB, created by Basuke Suzuki on 2018-08-28 13:43:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-28 13:43:07 PDT

Size: 1.46 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f6b8722228a..9de1ab2c2e4 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl][WebKit] Bugfix on redirect.
>+        https://bugs.webkit.org/show_bug.cgi?id=189056
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Forget to call updateFromDelegatePreservingOldProperties in continueWillSendRequest like other ports do.
>+
>+        * NetworkProcess/NetworkLoad.cpp:
>+        (WebKit::NetworkLoad::continueWillSendRequest):
>+
> 2018-08-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
> 
>         [Curl] Match the interface used in NetworkDataTask and ResourceHandle.
>diff --git a/Source/WebKit/NetworkProcess/NetworkLoad.cpp b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>index 378a548441d..a8c36cdb167 100644
>--- a/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>@@ -151,7 +151,7 @@ void NetworkLoad::continueWillSendRequest(WebCore::ResourceRequest&& newRequest)
> {
> #if PLATFORM(COCOA)
>     m_currentRequest.updateFromDelegatePreservingOldProperties(newRequest.nsURLRequest(HTTPBodyUpdatePolicy::DoNotUpdateHTTPBody));
>-#elif USE(SOUP)
>+#elif USE(SOUP) || USE(CURL)
>     // FIXME: Implement ResourceRequest::updateFromDelegatePreservingOldProperties. See https://bugs.webkit.org/show_bug.cgi?id=126127.
>     m_currentRequest.updateFromDelegatePreservingOldProperties(newRequest);
> #endif

Flags:

achristensen: review+
achristensen: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189056: 348335 | 348504