Attachment 348272 Details for Bug 188946 – Patch

[patch] Patch

bug-188946-20180828004459.patch (text/plain), 2.32 KB, created by Devin Rousso on 2018-08-28 00:44:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-08-28 00:44:59 PDT

Size: 2.32 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index aca81e50605fd17f184bba6c95518eab29c53ad0..f92cabbe65300802062634d615a3a712f1330515 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-08-28  Devin Rousso  <drousso@apple.com>
>+
>+        console.log() shows (anonymous function) instead of the passed string when a certain format is used
>+        https://bugs.webkit.org/show_bug.cgi?id=188946
>+        <rdar://problem/43756428>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Stack trace URLs are much more likely to follow the following format:
>+
>+            <protocol>://<path>:<line>:<column>
>+
>+        Modify the test regexp to always require that a protocol exists and to check that there are
>+        no ":" inside the protocol or path. Additionally, stack traces usually have more than one
>+        frame, so return false if there isn't more than one line.
>+
>+        * UserInterface/Models/StackTrace.js:
>+        (WI.StackTrace.isLikelyStackTrace):
>+
> 2018-08-27  Keith Rollin  <krollin@apple.com>
> 
>         Unreviewed build fix -- disable LTO for production builds
>diff --git a/Source/WebInspectorUI/UserInterface/Models/StackTrace.js b/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
>index ca72995416cc7b4625c924f6f86dd7a9ea4b9e77..7f363b6b6a515ad26359cbce28d5aadf3b68dff1 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
>@@ -80,11 +80,14 @@ WI.StackTrace = class StackTrace
>         if (/^[^a-z$_]/i.test(stack[0]))
>             return false;
> 
>+        if (stack.length - stack.replace(/[\n\r]/g, "").length <= 1)
>+            return false;
>+
>+        const reasonablyLongProtocolLength = 10;
>         const reasonablyLongLineLength = 500;
>         const reasonablyLongNativeMethodLength = 120;
>-        const stackTraceLine = `(.{1,${reasonablyLongLineLength}}:\\d+:\\d+|eval code|.{1,${reasonablyLongNativeMethodLength}}@\\[native code\\])`;
>+        const stackTraceLine = `([^:]{1,${reasonablyLongProtocolLength}}://[^:]{1,${reasonablyLongLineLength}}:\\d+:\\d+|eval code|.{1,${reasonablyLongNativeMethodLength}}@\\[native code\\])`;
>         const stackTrace = new RegExp(`^${stackTraceLine}(\\n${stackTraceLine})*$`, "g");
>-
>         return stackTrace.test(stack);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188946: 348079 | 348271 | 348272 | 348278 | 348282 | 348283 | 348303 | 348316 | 348356