Attachment 348173 Details for Bug 188993 – Patch

[patch] Patch

bug-188993-20180827111819.patch (text/plain), 1.40 KB, created by Myles C. Maxfield on 2018-08-27 11:18:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-08-27 11:18:20 PDT

Size: 1.40 KB

patch

obsolete

>Subversion Revision: 235385
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a0b9a02d491d3c7440ace8a2241c4e5350c5f514..d87810615b022236d2332d8d3ce6e13570625423 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-27  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Null pointer deref in WidthIterator
>+        https://bugs.webkit.org/show_bug.cgi?id=188993
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/WidthIterator.cpp:
>+        (WebCore::WidthIterator::advanceInternal):
>+
> 2018-08-27  Keith Rollin  <krollin@apple.com>
> 
>         Build system support for LTO
>diff --git a/Source/WebCore/platform/graphics/WidthIterator.cpp b/Source/WebCore/platform/graphics/WidthIterator.cpp
>index 051409292af7e755e835e4e7050ec3eb7f347581..9bde879703f6a4df114996a2a8cc77e1c717fc59 100644
>--- a/Source/WebCore/platform/graphics/WidthIterator.cpp
>+++ b/Source/WebCore/platform/graphics/WidthIterator.cpp
>@@ -345,7 +345,7 @@ inline unsigned WidthIterator::advanceInternal(TextIterator& textIterator, Glyph
>         previousCharacter = character;
>     }
> 
>-    if (leftoverJustificationWidth) {
>+    if (glyphBuffer && leftoverJustificationWidth) {
>         if (m_forTextEmphasis)
>             glyphBuffer->add(lastFontData->zeroWidthSpaceGlyph(), lastFontData, leftoverJustificationWidth, m_run.length() - 1);
>         else

Actions: View | Formatted Diff | Diff

Attachments on bug 188993: 348173 | 348175 | 348192