Attachment 348162 Details for Bug 188991 – Patch

[patch] Patch

bug-188991-20180827104828.patch (text/plain), 3.06 KB, created by Thomas Denney on 2018-08-27 10:48:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Denney

Created: 2018-08-27 10:48:31 PDT

Size: 3.06 KB

patch

obsolete

>Subversion Revision: 235371
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 8f7639f6aa43120de446aebbf7e83a225ba3f7d5..19d801670652d1c6d7b3b37fec0595e1d5595bd9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,27 @@
>+2018-08-27  Thomas Denney  <tdenney@apple.com>
>+
>+        Avoid an exception in the interactive interpreter
>+        https://bugs.webkit.org/show_bug.cgi?id=188991
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebGPUShadingLanguageRI/index.html: Corrects a typo in the name of a
>+        local variable
>+
>+2018-08-27  Thomas Denney  <tdenney@apple.com>
>+
>+        Allow new vector types to work with the interactive interpreter
>+        https://bugs.webkit.org/show_bug.cgi?id=188988
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
>+        (FlattenedStructOffsetGatherer.prototype.visitTypeRef): Do not
>+        unncessarily visit the type arguments of a TypeRef, as by this point
>+        there are none that are relevant.
>+        * WebGPUShadingLanguageRI/Intrinsics.js:
>+        (Intrinsics): Treat VectorType as a primitive type.
>+
> 2018-08-27  Alex Christensen  <achristensen@webkit.org>
> 
>         Fix GTK build.
>diff --git a/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js b/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js
>index 1970f8ed932cd3530a48dc31af8c9c4240dde8d0..53c8716c45046f87fc4f6cd53fa9f7a42c53e165 100644
>--- a/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js
>+++ b/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js
>@@ -59,7 +59,6 @@ class FlattenedStructOffsetGatherer extends Visitor {
>     
>     visitTypeRef(node)
>     {
>-        super.visitTypeRef(node);
>         Node.visit(node.type, this);
>     }
> 
>diff --git a/Tools/WebGPUShadingLanguageRI/Intrinsics.js b/Tools/WebGPUShadingLanguageRI/Intrinsics.js
>index e9c3d1b34176a4bfd79b4f4494b37be0e5e9b380..72290632982ee108412e88b0882e41ce85a7301d 100644
>--- a/Tools/WebGPUShadingLanguageRI/Intrinsics.js
>+++ b/Tools/WebGPUShadingLanguageRI/Intrinsics.js
>@@ -311,6 +311,7 @@ class Intrinsics {
>             for (let vectorSize of VectorElementSizes) {
>                 this._map.set(`native typedef vector<${vectorType}, ${vectorSize}>`, type => {
>                     this[`vector<${vectorType}, ${vectorSize}>`] = type;
>+                    type.isPrimitive = true;
>                 });
>             }
>         }
>diff --git a/Tools/WebGPUShadingLanguageRI/index.html b/Tools/WebGPUShadingLanguageRI/index.html
>index 2efadbd64744edff267378d5a96d49be297b41c5..17d0c20c9fd638fb30eed7bb62204aa097c5acbd 100644
>--- a/Tools/WebGPUShadingLanguageRI/index.html
>+++ b/Tools/WebGPUShadingLanguageRI/index.html
>@@ -383,7 +383,7 @@ function selectedShadersChanged(fromCompilation = false) {
>     }
>     if (!found)
>         linkError("Could not find the stageIn argument in the fragment shader!");
>-    if (func.parameters.length > 1)
>+    if (currentFragmentShader.parameters.length > 1)
>         linkError("Fragment shaders currently don't know how to have any other arguments other than stageIn.");
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188991: 348162 | 348165