Attachment 348161 Details for Bug 188990 – Patch

[patch] Patch

bug-188990-20180827104543.patch (text/plain), 2.19 KB, created by Simon Fraser (smfr) on 2018-08-27 10:45:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-08-27 10:45:43 PDT

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 235338
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 302c942a8cb7e43d5dfc46d5cbb1895e79b4b176..93677a2040455a600566ffcec69238a60ff50c25 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-08-27  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Improve the showAllDocuments logging
>+        https://bugs.webkit.org/show_bug.cgi?id=188990
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Improve the output triggered by "notifyutil -p com.apple.WebKit.showAllDocuments" to denote
>+        SVG documents (which often have no URL), and to show the refCount and referencingNodeCount,
>+        which helps with leak debugging.
>+        
>+        Sample output:
>+
>+        2 live documents:
>+        Document 0x1236f1200 3 (refCount 6, referencingNodeCount 580) https://webkit.org/
>+        SVGDocument 0x134b60000 13 (refCount 1, referencingNodeCount 197) 
>+
>+        * page/mac/PageMac.mm:
>+        (WebCore::Page::platformInitialize):
>+
> 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Click event from click() is not composed
>diff --git a/Source/WebCore/page/mac/PageMac.mm b/Source/WebCore/page/mac/PageMac.mm
>index e743d6ea87c05b00770639524658384c9050d34a..44e940c1ee45968ead1fc9234570d9d91dede833 100644
>--- a/Source/WebCore/page/mac/PageMac.mm
>+++ b/Source/WebCore/page/mac/PageMac.mm
>@@ -36,6 +36,7 @@
> #import "LayoutTreeBuilder.h"
> #import "Logging.h"
> #import "RenderObject.h"
>+#import "SVGDocument.h"
> #import <pal/Logging.h>
> 
> #if PLATFORM(IOS)
>@@ -77,7 +78,8 @@ void Page::platformInitialize()
> 
>             WTFLogAlways("%u live documents:", Document::allDocuments().size());
>             for (const auto* document : Document::allDocuments()) {
>-                WTFLogAlways("Document %p %s", document, document->url().string().utf8().data());
>+                const char* documentType = is<SVGDocument>(document) ? "SVGDocument" : "Document";
>+                WTFLogAlways("%s %p %llu (refCount %d, referencingNodeCount %d) %s", documentType, document, document->identifier().toUInt64(), document->refCount(), document->referencingNodeCount(), document->url().string().utf8().data());
>             }
>         });
>     });

Actions: View | Formatted Diff | Diff

Attachments on bug 188990: 348161