Attachment 348151 Details for Bug 188959 – Patch

[patch] Patch

bug-188959-20180827092920.patch (text/plain), 1.79 KB, created by Devin Rousso on 2018-08-27 09:29:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-08-27 09:29:21 PDT

Size: 1.79 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 434d03e3d059b79b866563566c9d695c244a7a2d..237a6cc7142be96d1d597f9039a4d664bd583166 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-27  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
>+        https://bugs.webkit.org/show_bug.cgi?id=188959
>+
>+        Reviewed by Brian Burg.
>+
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.prototype.set hidden):
>+        Only set `focusedTreeElement` if the `WI.TreeElement` is selected and not hidden. There is
>+        no reason to focus a hidden or unselected `WI.TreeElement`.
>+
> 2018-08-23  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Color picker: can't enter decimal numbers for opacity
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index c21a593b87eed2d068da3f0c80ed8af68ad34434..d487147c951571aef553a77869da05ef47a35b0b 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -166,7 +166,10 @@ WI.TreeElement = class TreeElement extends WI.Object
>             this._childrenListNode.hidden = this._hidden;
> 
>         if (this.treeOutline) {
>-            this.treeOutline.soon.updateVirtualizedElements(this);
>+            let focusedTreeElement = null;
>+            if (!this._hidden && this.selected)
>+                focusedTreeElement = this;
>+            this.treeOutline.soon.updateVirtualizedElements(focusedTreeElement);
> 
>             this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementVisibilityDidChange, {element: this});
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 188959: 348115 | 348151