Attachment 348143 Details for Bug 188983 – Patch

[patch] Patch

bug-188983-20180827103855.patch (text/plain), 2.68 KB, created by Patrick Griffis on 2018-08-27 07:38:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Griffis

Created: 2018-08-27 07:38:56 PDT

Size: 2.68 KB

patch

obsolete

>Subversion Revision: 235362
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 2d2ac0bfa067180707e0a5bb5aae74ef2eb3ae60..8b8a52f4ed44868032aa22ed98fd883e97dd3c5f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-08-27  Patrick Griffis  <pgriffis@igalia.com>
>+
>+        [GTK][JSC] Add warn_unused_result attribute to some APIs
>+        https://bugs.webkit.org/show_bug.cgi?id=188983
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * API/glib/JSCValue.h:
>+
> 2018-08-24  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [JSC] Array.prototype.reverse modifies JSImmutableButterfly
>diff --git a/Source/JavaScriptCore/API/glib/JSCValue.h b/Source/JavaScriptCore/API/glib/JSCValue.h
>index eb5f5fe13eb6f962b2211780c727b17c5eaa1af5..fae6267a6ee46960124b8c398be7c4fe803c9ba4 100644
>--- a/Source/JavaScriptCore/API/glib/JSCValue.h
>+++ b/Source/JavaScriptCore/API/glib/JSCValue.h
>@@ -182,13 +182,13 @@ JSC_API JSCValue *
> jsc_value_object_invoke_method            (JSCValue             *value,
>                                            const char           *name,
>                                            GType                 first_parameter_type,
>-                                           ...);
>+                                           ...) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API JSCValue *
> jsc_value_object_invoke_methodv           (JSCValue             *value,
>                                            const char           *name,
>                                            guint                 n_parameters,
>-                                           JSCValue            **parameters);
>+                                           JSCValue            **parameters) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API void
> jsc_value_object_define_property_data     (JSCValue             *value,
>@@ -240,12 +240,12 @@ jsc_value_is_function                     (JSCValue             *value);
> JSC_API JSCValue *
> jsc_value_function_call                   (JSCValue             *value,
>                                            GType                 first_parameter_type,
>-                                           ...);
>+                                           ...) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API JSCValue *
> jsc_value_function_callv                  (JSCValue             *value,
>                                            guint                 n_parameters,
>-                                           JSCValue            **parameters);
>+                                           JSCValue            **parameters) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API gboolean
> jsc_value_is_constructor                  (JSCValue             *value);

Actions: View | Formatted Diff | Diff

Attachments on bug 188983: 348143