Attachment 348131 Details for Bug 188893 – Patch

[patch] Patch

bug-188893-20180827204944.patch (text/plain), 2.02 KB, created by Fujii Hironori on 2018-08-27 04:49:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-08-27 04:49:45 PDT

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 235271
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 50081f9500ade7fbaff3c9b8b769845e7b737a23..2f7e9e47cf67cba2a3793f87be7c8d5dd4ab5ff1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,31 @@
>+2018-08-27  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        REGRESSION(r234879): Hundreds of layout tests are timing out in WinCairo Debug
>+        https://bugs.webkit.org/show_bug.cgi?id=188893
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        HashTable<WebCore::Color, ...>::add didn't finish since r234879.
>+        HashTable was filled with Color::invalidRGBAColor
>+        (0x0000000000000001), not Color::emptyHashValue(0xFFFFFFFFFFFFFFFB).
>+        Then, HashTable::add can't find an empty slot in the loop.
>+
>+        This issue happened only in Ninja builds, but in MSBuild builds.
>+
>+        In the executable built by MSBuild,
>+        GenericHashTraits<WebCore::Color>::constructEmptyValue calls
>+        HashTraits<WebCore::Color>::emptyValue as expected. But, one built
>+        by Ninja, it calls GenericHashTraits<WebCore::Color>::emptyValue
>+        which returns Color::invalidRGBAColor.
>+
>+        In DebugPageOverlays.cpp, HashMap is used with Color without
>+        #include "ColorHash.h". Then, the expected specialization
>+        HashTraits<WebCore::Color> was not used.
>+
>+        Covered by existing tests.
>+
>+        * page/DebugPageOverlays.cpp: Added #include "ColorHash.h".
>+
> 2018-08-23  Simon Fraser  <simon.fraser@apple.com>
> 
>         Add support for dumping GC heap snapshots, and a viewer
>diff --git a/Source/WebCore/page/DebugPageOverlays.cpp b/Source/WebCore/page/DebugPageOverlays.cpp
>index 595aa41854b849c3da82ae23134d10b9165b9234..ed027fae83cc23edbf52b1e3b230f947f3fe8b04 100644
>--- a/Source/WebCore/page/DebugPageOverlays.cpp
>+++ b/Source/WebCore/page/DebugPageOverlays.cpp
>@@ -26,6 +26,7 @@
> #include "config.h"
> #include "DebugPageOverlays.h"
> 
>+#include "ColorHash.h"
> #include "ElementIterator.h"
> #include "FrameView.h"
> #include "GraphicsContext.h"

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188893: 347998 | 348131