Attachment 348115 Details for Bug 188959 – Patch

[patch] Patch

bug-188959-20180826204157.patch (text/plain), 1.68 KB, created by Devin Rousso on 2018-08-26 20:41:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-08-26 20:41:58 PDT

Size: 1.68 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 434d03e3d059b79b866563566c9d695c244a7a2d..45279cd73351a4aa37c5ae94c6030e8ed3a35ced 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-26  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
>+        https://bugs.webkit.org/show_bug.cgi?id=188959
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.prototype.set hidden):
>+        Only set `focusedTreeElement` if the `WI.TreeElement` is selected and not hidden. There is
>+        no reason to focus a hidden or unselected `WI.TreeElement`.
>+
> 2018-08-23  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Color picker: can't enter decimal numbers for opacity
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index c21a593b87eed2d068da3f0c80ed8af68ad34434..fe633f6cde9ef3a0389e77c9d66bc41525e2bdef 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -166,7 +166,7 @@ WI.TreeElement = class TreeElement extends WI.Object
>             this._childrenListNode.hidden = this._hidden;
> 
>         if (this.treeOutline) {
>-            this.treeOutline.soon.updateVirtualizedElements(this);
>+            this.treeOutline.soon.updateVirtualizedElements(!this._hidden && this.selected ? this : null);
> 
>             this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementVisibilityDidChange, {element: this});
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 188959: 348115 | 348151