Attachment 348077 Details for Bug 188945 – Patch

[patch] Patch

bug-188945-20180825225752.patch (text/plain), 2.58 KB, created by Yusuke Suzuki on 2018-08-25 06:57:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-08-25 06:57:53 PDT

Size: 2.58 KB

patch

obsolete

>Subversion Revision: 235338
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 302c942a8cb7e43d5dfc46d5cbb1895e79b4b176..f6ca8827f8203451df5c7e5e04efe7836520ea75 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-25  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        Shrink size of HTMLCollection
>+        https://bugs.webkit.org/show_bug.cgi?id=188945
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Shrink the size of HTMLCollection by reordering members.
>+
>+        No behavior change.
>+
>+        * html/HTMLCollection.cpp:
>+        (WebCore::HTMLCollection::HTMLCollection):
>+        * html/HTMLCollection.h:
>+
> 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Click event from click() is not composed
>diff --git a/Source/WebCore/html/HTMLCollection.cpp b/Source/WebCore/html/HTMLCollection.cpp
>index 5f596a32ec624213fa7ab442a21b86862af7aacf..3e34a36d2b8f4aacb343207be077806d1a948444 100644
>--- a/Source/WebCore/html/HTMLCollection.cpp
>+++ b/Source/WebCore/html/HTMLCollection.cpp
>@@ -108,10 +108,10 @@ static NodeListInvalidationType invalidationTypeExcludingIdAndNameAttributes(Col
> }
> 
> HTMLCollection::HTMLCollection(ContainerNode& ownerNode, CollectionType type)
>-    : m_ownerNode(ownerNode)
>-    , m_collectionType(type)
>+    : m_collectionType(type)
>     , m_invalidationType(invalidationTypeExcludingIdAndNameAttributes(type))
>     , m_rootType(rootTypeFromCollectionType(type))
>+    , m_ownerNode(ownerNode)
> {
>     ASSERT(m_rootType == static_cast<unsigned>(rootTypeFromCollectionType(type)));
>     ASSERT(m_invalidationType == static_cast<unsigned>(invalidationTypeExcludingIdAndNameAttributes(type)));
>diff --git a/Source/WebCore/html/HTMLCollection.h b/Source/WebCore/html/HTMLCollection.h
>index 75ac434518076609a41af2a4af751710d4eb6cd0..41d77fc77246d62cadb45412681eb872d0b12a40 100644
>--- a/Source/WebCore/html/HTMLCollection.h
>+++ b/Source/WebCore/html/HTMLCollection.h
>@@ -101,14 +101,15 @@ class HTMLCollection : public NodeList {
>     enum RootType { IsRootedAtNode, IsRootedAtDocument };
>     static RootType rootTypeFromCollectionType(CollectionType);
> 
>-    Ref<ContainerNode> m_ownerNode;
>-
>-    mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
>     mutable Lock m_namedElementCacheAssignmentLock;
>-    
>+
>     const unsigned m_collectionType : 5;
>     const unsigned m_invalidationType : 4;
>     const unsigned m_rootType : 1;
>+
>+    Ref<ContainerNode> m_ownerNode;
>+
>+    mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
> };
> 
> inline ContainerNode& HTMLCollection::rootNode() const

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188945: 348077