WebKit Bugzilla
Attachment 348049 Details for
Bug 170211
: Click event from click() is not composed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Fixes the bug
bug-170211-20180824153823.patch (text/plain), 3.11 KB, created by
Ryosuke Niwa
on 2018-08-24 15:38:24 PDT
(
hide
)
Description:
Fixes the bug
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2018-08-24 15:38:24 PDT
Size:
3.11 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 235334) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2018-08-24 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Click event from click() is not composed >+ https://bugs.webkit.org/show_bug.cgi?id=170211 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fixed the bug. All simulated clicks should be composed regardless of whether it's trusted or not. >+ See: https://html.spec.whatwg.org/multipage/interaction.html#dom-click >+ https://html.spec.whatwg.org/multipage/webappapis.html#fire-a-synthetic-mouse-event >+ >+ * dom/SimulatedClick.cpp: >+ > 2018-08-24 Jer Noble <jer.noble@apple.com> > > Using Touch Bar to scrub video on Youtube results in video playback freeze >Index: Source/WebCore/dom/SimulatedClick.cpp >=================================================================== >--- Source/WebCore/dom/SimulatedClick.cpp (revision 235334) >+++ Source/WebCore/dom/SimulatedClick.cpp (working copy) >@@ -44,7 +44,7 @@ public: > > private: > SimulatedMouseEvent(const AtomicString& eventType, RefPtr<WindowProxy>&& view, RefPtr<Event>&& underlyingEvent, Element& target, SimulatedClickSource source) >- : MouseEvent(eventType, CanBubble::Yes, IsCancelable::Yes, source == SimulatedClickSource::Bindings ? IsComposed::No : IsComposed::Yes, >+ : MouseEvent(eventType, CanBubble::Yes, IsCancelable::Yes, IsComposed::Yes, > underlyingEvent ? underlyingEvent->timeStamp() : MonotonicTime::now(), WTFMove(view), /* detail */ 0, > { }, { }, { }, modifiersFromUnderlyingEvent(underlyingEvent), 0, 0, nullptr, 0, 0, nullptr, IsSimulated::Yes) > { >Index: LayoutTests/imported/w3c/ChangeLog >=================================================================== >--- LayoutTests/imported/w3c/ChangeLog (revision 235334) >+++ LayoutTests/imported/w3c/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2018-08-24 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Click event from click() is not composed >+ https://bugs.webkit.org/show_bug.cgi?id=170211 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Rebaselined the test now that all test cases pass. >+ >+ * web-platform-tests/shadow-dom/event-composed-expected.txt: >+ > 2018-08-24 Youenn Fablet <youenn@apple.com> > > libwebrtc PeerConnection::AddTrack sometimes fail >Index: LayoutTests/imported/w3c/web-platform-tests/shadow-dom/event-composed-expected.txt >=================================================================== >--- LayoutTests/imported/w3c/web-platform-tests/shadow-dom/event-composed-expected.txt (revision 235334) >+++ LayoutTests/imported/w3c/web-platform-tests/shadow-dom/event-composed-expected.txt (working copy) >@@ -7,5 +7,5 @@ PASS A synthetic MouseEvent should be sc > PASS A synthetic MouseEvent with composed=true should not be scoped > PASS A synthetic FocusEvent should be scoped by default > PASS A synthetic FocusEvent with composed=true should not be scoped >-FAIL A UA click event should not be scoped assert_equals: expected 3 but got 2 >+PASS A UA click event should not be scoped >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
wenson_hsieh
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 170211
: 348049