Attachment 348044 Details for Bug 188906 – Patch

[patch] Patch

bug-188906-20180824150358.patch (text/plain), 1.69 KB, created by Sihui Liu on 2018-08-24 15:03:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-24 15:03:59 PDT

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 235323
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0009c37481481a3cfd431aa3d506c85cd834db42..147a99a83004d53cbc260eef15cb72db5dcfa237 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-24  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
>+        https://bugs.webkit.org/show_bug.cgi?id=188906
>+        <rdar://problem/42875795>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add callback in early return.
>+
>+        * UIProcess/WebCookieManagerProxy.cpp:
>+        (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
>+
> 2018-08-24  Alex Christensen  <achristensen@webkit.org>
> 
>         Introduce _WKInspector
>diff --git a/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp b/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>index 08cff58eb29c3904d6fe95d384947fcb691bd770..0a20d854f44f21abc5a43bbd0d77c8692f8f2769 100644
>--- a/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>@@ -251,8 +251,10 @@ void WebCookieManagerProxy::setHTTPCookieAcceptPolicy(PAL::SessionID, HTTPCookie
>     processPool()->setInitialHTTPCookieAcceptPolicy(policy);
> #endif
> 
>-    if (!processPool()->networkProcess())
>+    if (!processPool()->networkProcess()) {
>+        callbackFunction(CallbackBase::Error::None);
>         return;
>+    }
> 
>     auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->ensureNetworkProcess().throttler().backgroundActivityToken());
>     processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));

Actions: View | Formatted Diff | Diff

Attachments on bug 188906: 347966 | 348044