Attachment 348020 Details for Bug 188908 – PATCH

[patch] PATCH

188908.diff (text/plain), 1.69 KB, created by Basuke Suzuki on 2018-08-24 10:31:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-24 10:31:47 PDT

Size: 1.69 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 48c8b60d70b..35043be74da 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-24  Christopher Reid  <chris.reid@sony.com>
>+
>+        [Curl] Implement deleteCookie()
>+        https://bugs.webkit.org/show_bug.cgi?id=188908
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Support deleting cookies from the web inspector
>+
>+        Tested from the web inspector.
>+
>+        * platform/network/curl/CookieJarCurlDatabase.cpp:
>+        (WebCore::CookieJarCurlDatabase::deleteCookie const):
>+
> 2018-08-20  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [CMake] Sync unified build with Cocoa ports
>diff --git a/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp b/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>index fad9d94ac32..5e8454aa54a 100644
>--- a/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>+++ b/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>@@ -113,9 +113,10 @@ bool CookieJarCurlDatabase::getRawCookies(const NetworkStorageSession& session,
>     return cookieJarDB.searchCookies(firstParty.string(), std::nullopt, std::nullopt, std::nullopt, rawCookies);
> }
> 
>-void CookieJarCurlDatabase::deleteCookie(const NetworkStorageSession&, const URL&, const String&) const
>+void CookieJarCurlDatabase::deleteCookie(const NetworkStorageSession& session, const URL& url, const String& name) const
> {
>-    // FIXME: Not yet implemented
>+    CookieJarDB& cookieJarDB = session.cookieDatabase();
>+    cookieJarDB.deleteCookie(url, name);
> }
> 
> void CookieJarCurlDatabase::getHostnamesWithCookies(const NetworkStorageSession&, HashSet<String>&) const

Actions: View | Formatted Diff | Diff

Attachments on bug 188908: 348020