Attachment 348005 Details for Bug 188919 – Patch

[patch] Patch

bug-188919-20180824171317.patch (text/plain), 1.86 KB, created by Adrian Perez on 2018-08-24 07:13:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2018-08-24 07:13:18 PDT

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 235316
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 66caabc4ef44adad830993a4177c44640ca2420d..10534f9e2fcc6686e4c45753fdcc7acb61e0dfc9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-24  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [FreeType] Do not cast through GLib types in FontCustomPlatformDataFreeType.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=188919
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests needed.
>+
>+        * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
>+        (WebCore::FontCustomPlatformData::FontCustomPlatformData): Cast
>+        through "void (*)(void)" instead of GCallback to avoid the warning
>+        produced by -Wcast-function-type.
>+
> 2018-08-24  Frederic Wang  <fwang@igalia.com>
> 
>         Remove ScrollByPrecisePixel granularity
>diff --git a/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp b/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
>index bd9cd0009afba09ef51ed4e8e0fc2c44f11f2faf..53625df7acf4c45d75713cee0967c13c77a4eb87 100644
>--- a/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
>+++ b/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
>@@ -48,7 +48,7 @@ FontCustomPlatformData::FontCustomPlatformData(FT_Face freeTypeFace, SharedBuffe
>     // this cairo_font_face_t is destroyed, it cleans up the FreeType face as well.
>     static cairo_user_data_key_t freeTypeFaceKey;
>     cairo_font_face_set_user_data(m_fontFace, &freeTypeFaceKey, freeTypeFace,
>-        reinterpret_cast<cairo_destroy_func_t>(reinterpret_cast<GCallback>(FT_Done_Face)));
>+        reinterpret_cast<cairo_destroy_func_t>(reinterpret_cast<void(*)(void)>(FT_Done_Face)));
> }
> 
> FontCustomPlatformData::~FontCustomPlatformData()

Actions: View | Formatted Diff | Diff

Attachments on bug 188919: 348003 | 348005