Attachment 348001 Details for Bug 188918 – [CMake] Remove stale comment from WebKitFeatures.cmake

[patch] [CMake] Remove stale comment from WebKitFeatures.cmake

bug-188918-20180824074659.patch (text/plain), 1.44 KB, created by Michael Catanzaro on 2018-08-24 05:47:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-08-24 05:47:00 PDT

Size: 1.44 KB

patch

obsolete

>Subversion Revision: 235210
>diff --git a/Source/cmake/WebKitFeatures.cmake b/Source/cmake/WebKitFeatures.cmake
>index 0d4b84359d0ae8b4bb8a1442596db354a995fd5b..b582e92e5ab9c42884000f03fe4bcbf85db9a4af 100644
>--- a/Source/cmake/WebKitFeatures.cmake
>+++ b/Source/cmake/WebKitFeatures.cmake
>@@ -3,10 +3,6 @@
> # Options*.cmake, but should do so only if there is strong reason to
> # deviate from the defaults of the WebKit project (e.g. if the feature
> # requires platform-specific implementation that does not exist).
>-#
>-# Most defaults in this file affect end users but not developers.
>-# Defaults for development builds are set in FeatureList.pm. Most all
>-# features enabled here should also be enabled in FeatureList.pm.
> 
> set(_WEBKIT_AVAILABLE_OPTIONS "")
> 
>diff --git a/ChangeLog b/ChangeLog
>index 2e1a19ebd9075c490315953a55ae76e8b7554ec9..d25b4216e687292bf2147f3996d934df9c08a5ac 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-24  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [CMake] Remove stale comment from WebKitFeatures.cmake
>+        https://bugs.webkit.org/show_bug.cgi?id=188918
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This comment at the top of WebKitFeatures.cmake is no longer accurate because feature defaults are no longer defined in FeatureList.pm (thank goodness!)
>+
>+        * Source/cmake/WebKitFeatures.cmake:
>+
> 2018-08-21  Patrick Griffis  <pgriffis@igalia.com>
> 
>         [GTK][WPE] Implement subprocess sandboxing

Actions: View | Formatted Diff | Diff

Attachments on bug 188918: 348001