Attachment 348000 Details for Bug 188915 – Patch

[patch] Patch

bug-188915-20180824112538.patch (text/plain), 3.92 KB, created by Frédéric Wang (:fredw) on 2018-08-24 02:25:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2018-08-24 02:25:39 PDT

Size: 3.92 KB

patch

obsolete

>Subversion Revision: 235225
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f2d9feb7dc124859d254b517dbeba0b171c6d538..7e8eab1171fcf4ca8b9ad9fe0f339391f23cb881 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-08-24  Frederic Wang  <fwang@igalia.com>
>+
>+        Remove ScrollByPrecisePixel granularity
>+        https://bugs.webkit.org/show_bug.cgi?id=188915
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        ScrollByPrecisePixel was introduced in bug 87535 and bug 91020 for Chromium Linux/Windows but
>+        it is no longer used.
>+
>+        No new tests, behavior unchanged.
>+
>+        * platform/ScrollAnimatorSmooth.cpp:
>+        (WebCore::ScrollAnimatorSmooth::scroll): Remove special handling for ScrollByPrecisePixel.
>+        * platform/ScrollTypes.h: Remove ScrollByPrecisePixel, it is never used.
>+        * platform/ScrollableArea.cpp:
>+        (WebCore::ScrollableArea::scroll): Remove special handling for ScrollByPrecisePixel.
>+        * platform/gtk/ScrollAnimatorGtk.cpp:
>+        (WebCore::ScrollAnimatorGtk::scroll): Remove special handling for ScrollByPrecisePixel.
>+
> 2018-08-23  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Floating] Decouple the incoming floats and floats already placed in the list
>diff --git a/Source/WebCore/platform/ScrollAnimatorSmooth.cpp b/Source/WebCore/platform/ScrollAnimatorSmooth.cpp
>index 27562d460943355a6db35ca47d6596e5e42fd398..defc3f1978f98f54154da3195b3a4765b4e6f654 100644
>--- a/Source/WebCore/platform/ScrollAnimatorSmooth.cpp
>+++ b/Source/WebCore/platform/ScrollAnimatorSmooth.cpp
>@@ -60,7 +60,7 @@ ScrollAnimatorSmooth::~ScrollAnimatorSmooth() = default;
> 
> bool ScrollAnimatorSmooth::scroll(ScrollbarOrientation orientation, ScrollGranularity granularity, float step, float multiplier)
> {
>-    if (!m_scrollableArea.scrollAnimatorEnabled() || granularity == ScrollByPrecisePixel)
>+    if (!m_scrollableArea.scrollAnimatorEnabled())
>         return ScrollAnimator::scroll(orientation, granularity, step, multiplier);
> 
>     return m_animation->scroll(orientation, granularity, step, multiplier);
>diff --git a/Source/WebCore/platform/ScrollTypes.h b/Source/WebCore/platform/ScrollTypes.h
>index b928b73efb96ab76e21e2cf97bd15fb349ac9602..33f38c31168b0bc3bab4c51b91459f130d9afe4c 100644
>--- a/Source/WebCore/platform/ScrollTypes.h
>+++ b/Source/WebCore/platform/ScrollTypes.h
>@@ -108,8 +108,7 @@ enum ScrollGranularity : uint8_t {
>     ScrollByLine,
>     ScrollByPage,
>     ScrollByDocument,
>-    ScrollByPixel,
>-    ScrollByPrecisePixel
>+    ScrollByPixel
> };
> 
> enum ScrollElasticity {
>diff --git a/Source/WebCore/platform/ScrollableArea.cpp b/Source/WebCore/platform/ScrollableArea.cpp
>index 46e71eacbebdafce981493a66a0cf7363bfc3727..7b1d359dbc6368520c92f4cd2b23067d64660f7b 100644
>--- a/Source/WebCore/platform/ScrollableArea.cpp
>+++ b/Source/WebCore/platform/ScrollableArea.cpp
>@@ -127,7 +127,6 @@ bool ScrollableArea::scroll(ScrollDirection direction, ScrollGranularity granula
>         step = scrollbar->totalSize();
>         break;
>     case ScrollByPixel:
>-    case ScrollByPrecisePixel:
>         step = scrollbar->pixelStep();
>         break;
>     }
>diff --git a/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp b/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp
>index 444fe069cbb6ff65af1d6773d729147b79b3bea0..8366f469654f449691d9b363773a4d53ff627be4 100644
>--- a/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp
>+++ b/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp
>@@ -82,7 +82,7 @@ void ScrollAnimatorGtk::ensureSmoothScrollingAnimation()
> #if ENABLE(SMOOTH_SCROLLING)
> bool ScrollAnimatorGtk::scroll(ScrollbarOrientation orientation, ScrollGranularity granularity, float step, float multiplier)
> {
>-    if (!m_scrollableArea.scrollAnimatorEnabled() || granularity == ScrollByPrecisePixel)
>+    if (!m_scrollableArea.scrollAnimatorEnabled())
>         return ScrollAnimator::scroll(orientation, granularity, step, multiplier);
> 
>     ensureSmoothScrollingAnimation();

Actions: View | Formatted Diff | Diff

Attachments on bug 188915: 347994 | 348000