Attachment 347991 Details for Bug 188911 – Fix attempt

[patch] Fix attempt

bug-188911-20180823222858.patch (text/plain), 2.77 KB, created by Ryosuke Niwa on 2018-08-23 22:28:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-08-23 22:28:58 PDT

Size: 2.77 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 235273)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        fast/files/blob-network-process-crash.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=188911
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The flakiness appears to come from the web content process not getting notified of
>+        the termination of the network process in time. Wait for the network process to
>+        relaunch after terminating one by continuously fetch'ing itself with an increasing
>+        time interval until it succeeds.
>+
>+        * fast/files/blob-network-process-crash.html:
>+
> 2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Add a flaky failing test expectation to fast/files/blob-network-process-crash.html
>Index: LayoutTests/fast/files/blob-network-process-crash.html
>===================================================================
>--- LayoutTests/fast/files/blob-network-process-crash.html	(revision 235268)
>+++ LayoutTests/fast/files/blob-network-process-crash.html	(working copy)
>@@ -7,9 +7,14 @@ WebKit should not hit a debug assertion 
> 
> if (!window.testRunner)
>     document.write('This test requires testRunner and GCController');
>-else {
>+else
>+    runTest();
>+
>+async function runTest()
>+{
>     testRunner.dumpAsText();
>     testRunner.waitUntilDone();
>+    setTimeout(() => testRunner.notifyDone(), 3000);
> 
>     let blobs = new Array(100);
>     for (let i = 0; i < 100; i++) {
>@@ -20,19 +25,28 @@ else {
> 
>     testRunner.terminateNetworkProcess();
> 
>-    // FIXME: If we don't store the timer, timer sometimes never fires.
>-    window.timer = setTimeout(() => {
>-        const newBlob = new Blob(["some text"]);
>-        for (let i = 0; i < 100; i++) {
>-            for (let j = 0; j < 10; j++)
>-                blobs[i][j] = { };
>-        }
>-        blobs = null;
>-        GCController.collect();
>-        fetch('blob-network-process-crash.html').then(() => {
>-            testRunner.notifyDone();
>-        });
>-    }, 0);
>+    await waitForNetworkProcessToRelaunch();
>+    const newBlob = new Blob(["some text"]);
>+    for (let i = 0; i < 100; i++) {
>+        for (let j = 0; j < 10; j++)
>+            blobs[i][j] = { };
>+    }
>+    blobs = null;
>+    GCController.collect();
>+
>+    await fetch('blob-network-process-crash.html');
>+
>+    testRunner.notifyDone();
>+}
>+
>+let waitTime = 10;
>+function waitForNetworkProcessToRelaunch() {
>+    return fetch('blob-network-process-crash.html').catch(() => {
>+        return new Promise((resolve, reject) => {
>+            waitTime *= 1.2;
>+            setTimeout(() => waitForNetworkProcessToRelaunch().then(resolve), waitTime);
>+        })
>+    });
> }
> 
> </script>

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188911: 347991