Attachment 347966 Details for Bug 188906 – Patch

[patch] Patch

bug-188906-20180823160656.patch (text/plain), 1.99 KB, created by Sihui Liu on 2018-08-23 16:06:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-23 16:06:57 PDT

Size: 1.99 KB

patch

obsolete

>Subversion Revision: 235249
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3eca1c9b5317ab18e784b3e198bf099225882c91..5003f4a6c6cf8a934675f0ee2e7e162b5fa29164 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-08-23  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
>+        https://bugs.webkit.org/show_bug.cgi?id=188906
>+        <rdar://problem/43539661>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of 
>+        sharedCookieStorage. When we launch the network process later, we pass the 
>+        identifier of sharedCookieStorage to network process, so network process has the correct 
>+        cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the 
>+        setting message if the network process is not launched.
>+
>+        * UIProcess/WebCookieManagerProxy.cpp:
>+        (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
>+
> 2018-08-23  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234942.
>diff --git a/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp b/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>index 06ff06ea8e2f9bb487f430a1bed9ce165a295083..ec6f590e6536461538229e426c5f303d45a1b90b 100644
>--- a/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
>@@ -252,6 +252,9 @@ void WebCookieManagerProxy::setHTTPCookieAcceptPolicy(PAL::SessionID, HTTPCookie
>     processPool()->setInitialHTTPCookieAcceptPolicy(policy);
> #endif
> 
>+    if (!processPool()->networkProcess())
>+        return;
>+
>     auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->ensureNetworkProcess().throttler().backgroundActivityToken());
>     processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 188906: 347966 | 348044