Attachment 347965 Details for Bug 188905 – Patch

[patch] Patch

bug-188905-20180823160053.patch (text/plain), 7.14 KB, created by BJ Burg on 2018-08-23 16:00:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-08-23 16:00:53 PDT

Size: 7.14 KB

patch

obsolete

>Subversion Revision: 235253
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9d64ffe5c15c7ae901c4ed38979bee09c4579fca..5d8ce1a7bd66563fcf087fb12ebed6e08f9e83f7 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-08-23  Brian Burg  <bburg@apple.com>
>+
>+        Web Inspector: fix typos in some compositing reasons
>+        https://bugs.webkit.org/show_bug.cgi?id=188905
>+        <rdar://problem/43624825>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+        * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
>+        (WI.LayerTreeDetailsSidebarPanel.prototype._populateListOfCompositingReasons):
>+        (WI.LayerTreeDetailsSidebarPanel):
>+        * UserInterface/Views/Layers3DContentView.js:
>+        (WI.Layers3DContentView.prototype._updateReasonsList):
>+        (WI.Layers3DContentView):
>+
> 2018-08-23  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: support breakpoints for timers and animation-frame events
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index 024b3f2cdae9ef7b91deeca3ab6eb9b6437714ef..22c0d1a5820bc886a37235e449a7ad52825481ce 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -358,14 +358,14 @@ localizedStrings["Element has âblend-modeâ style"] = "Element has âblend-m
> localizedStrings["Element has âposition: fixedâ style"] = "Element has âposition: fixedâ style";
> localizedStrings["Element has âposition: stickyâ style"] = "Element has âposition: stickyâ style";
> localizedStrings["Element has âtransform-style: preserve-3dâ style"] = "Element has âtransform-style: preserve-3dâ style";
>-localizedStrings["Element has âwill-changeâ style with includes opacity, transform, transform-style, perspective, filter or backdrop-filter"] = "Element has âwill-changeâ style with includes opacity, transform, transform-style, perspective, filter or backdrop-filter";
>+localizedStrings["Element has âwill-changeâ style which includes opacity, transform, transform-style, perspective, filter or backdrop-filter"] = "Element has âwill-changeâ style which includes opacity, transform, transform-style, perspective, filter or backdrop-filter";
> localizedStrings["Element is <canvas>"] = "Element is <canvas>";
> localizedStrings["Element is <iframe>"] = "Element is <iframe>";
> localizedStrings["Element is <video>"] = "Element is <video>";
> localizedStrings["Element is a plug-in"] = "Element is a plug-in";
> localizedStrings["Element is a stacking context and has composited descendants with CSS blending applied"] = "Element is a stacking context and has composited descendants with CSS blending applied";
> localizedStrings["Element is animated"] = "Element is animated";
>-localizedStrings["Element is masked and composited descendants"] = "Element is masked and composited descendants";
>+localizedStrings["Element is masked and has composited descendants"] = "Element is masked and has composited descendants";
> localizedStrings["Element is the root element"] = "Element is the root element";
> localizedStrings["Element may overlap another compositing element"] = "Element may overlap another compositing element";
> localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js
>index 3156750983260d40261a7b2d38aa09dfd39507c1..7f09a95652fe6b0903734578a37f21e2da7952fb 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js
>@@ -425,7 +425,7 @@ WI.LayerTreeDetailsSidebarPanel = class LayerTreeDetailsSidebarPanel extends WI.
>         if (compositingReasons.opacityWithCompositedDescendants)
>             addReason(WI.UIString("Element has opacity applied and composited descendants"));
>         if (compositingReasons.maskWithCompositedDescendants)
>-            addReason(WI.UIString("Element is masked and composited descendants"));
>+            addReason(WI.UIString("Element is masked and has composited descendants"));
>         if (compositingReasons.reflectionWithCompositedDescendants)
>             addReason(WI.UIString("Element has a reflection and composited descendants"));
>         if (compositingReasons.filterWithCompositedDescendants)
>@@ -439,7 +439,7 @@ WI.LayerTreeDetailsSidebarPanel = class LayerTreeDetailsSidebarPanel extends WI.
>         if (compositingReasons.preserve3D)
>             addReason(WI.UIString("Element has âtransform-style: preserve-3dâ style"));
>         if (compositingReasons.willChange)
>-            addReason(WI.UIString("Element has âwill-changeâ style with includes opacity, transform, transform-style, perspective, filter or backdrop-filter"));
>+            addReason(WI.UIString("Element has âwill-changeâ style which includes opacity, transform, transform-style, perspective, filter or backdrop-filter"));
>         if (compositingReasons.root)
>             addReason(WI.UIString("Element is the root element"));
>         if (compositingReasons.blending)
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js b/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js
>index 57f3484fbc1b833faf2f1197ac7f0df513abd360..2b09818a4b6462ace258f1f451fb2d7b1ba3c739 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js
>@@ -510,7 +510,7 @@ WI.Layers3DContentView = class Layers3DContentView extends WI.ContentView
>         if (compositingReasons.opacityWithCompositedDescendants)
>             addReason(WI.UIString("Element has opacity applied and composited descendants"));
>         if (compositingReasons.maskWithCompositedDescendants)
>-            addReason(WI.UIString("Element is masked and composited descendants"));
>+            addReason(WI.UIString("Element is masked and has composited descendants"));
>         if (compositingReasons.reflectionWithCompositedDescendants)
>             addReason(WI.UIString("Element has a reflection and composited descendants"));
>         if (compositingReasons.filterWithCompositedDescendants)
>@@ -524,7 +524,7 @@ WI.Layers3DContentView = class Layers3DContentView extends WI.ContentView
>         if (compositingReasons.preserve3D)
>             addReason(WI.UIString("Element has âtransform-style: preserve-3dâ style"));
>         if (compositingReasons.willChange)
>-            addReason(WI.UIString("Element has âwill-changeâ style with includes opacity, transform, transform-style, perspective, filter or backdrop-filter"));
>+            addReason(WI.UIString("Element has âwill-changeâ style which includes opacity, transform, transform-style, perspective, filter or backdrop-filter"));
>         if (compositingReasons.root)
>             addReason(WI.UIString("Element is the root element"));
>         if (compositingReasons.blending)

Actions: View | Formatted Diff | Diff

Attachments on bug 188905: 347965