WebKit Bugzilla
Attachment 347944 Details for
Bug 188895
: YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
188895.patch (text/plain), 1.71 KB, created by
Michael Saboff
on 2018-08-23 11:58:39 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Michael Saboff
Created:
2018-08-23 11:58:39 PDT
Size:
1.71 KB
patch
obsolete
>Index: Source/JavaScriptCore/ChangeLog >=================================================================== >--- Source/JavaScriptCore/ChangeLog (revision 235231) >+++ Source/JavaScriptCore/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2018-08-23 Michael Saboff <msaboff@apple.com> >+ >+ YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag >+ https://bugs.webkit.org/show_bug.cgi?id=188895 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Found while working on another change. This will allow processing of nested >+ parenthesis that require saved ParenContext structures. >+ >+ * yarr/YarrJIT.cpp: >+ (JSC::Yarr::YarrGenerator::compile): >+ > 2018-08-22 Michael Saboff <msaboff@apple.com> > > https://bugs.webkit.org/show_bug.cgi?id=188859 >Index: Source/JavaScriptCore/yarr/YarrJIT.cpp >=================================================================== >--- Source/JavaScriptCore/yarr/YarrJIT.cpp (revision 235222) >+++ Source/JavaScriptCore/yarr/YarrJIT.cpp (working copy) >@@ -3545,11 +3545,6 @@ public: > } > #endif > >-#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS) >- if (m_containsNestedSubpatterns) >- codeBlock.setUsesPaternContextBuffer(); >-#endif >- > // We need to compile before generating code since we set flags based on compilation that > // are used during generation. > opCompileBody(m_pattern.m_body); >@@ -3565,6 +3560,11 @@ public: > if (m_disassembler) > m_disassembler->setStartOfCode(label()); > >+#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS) >+ if (m_containsNestedSubpatterns) >+ codeBlock.setUsesPaternContextBuffer(); >+#endif >+ > generateEnter(); > > Jump hasInput = checkInput();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188895
: 347944