Attachment 347941 Details for Bug 188894 – Set the rubber-band state from the event dispatcher thread

[patch] Set the rubber-band state from the event dispatcher thread

bug-188894-20180823114236.patch (text/plain), 2.16 KB, created by mitz on 2018-08-23 11:42:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-08-23 11:42:37 PDT

Size: 2.16 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 235231)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-08-23  Dan Bernstein  <mitz@apple.com>
>+
>+        [Cocoa] First scroll gesture in pinned, non-rubber-banding WKWebView may fail to initiate back/forward swipe
>+        https://bugs.webkit.org/show_bug.cgi?id=188894
>+        <rdar://problem/43651434>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/EventDispatcher.cpp:
>+        (WebKit::EventDispatcher::wheelEvent): Set the rubber-band state on the ScrollingTree
>+          synchronously rather than dispatching doing that to the scrolling thread. This is safe to
>+          do because ScrollingTree synchrnoizes access to the rubber-band state with an internal
>+          mutex.
>+
> 2018-08-23  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r235216.
>Index: Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp	(revision 235143)
>+++ Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp	(working copy)
>@@ -120,11 +120,8 @@ void EventDispatcher::wheelEvent(uint64_
>         // WebCore should always know the current state and know when it changes so the
>         // scrolling tree can be notified.
>         // We only need to do this at the beginning of the gesture.
>-        if (platformWheelEvent.phase() == PlatformWheelEventPhaseBegan) {
>-            ScrollingThread::dispatch([scrollingTree, canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom] {
>-                scrollingTree->setCanRubberBandState(canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom);
>-            });
>-        }
>+        if (platformWheelEvent.phase() == PlatformWheelEventPhaseBegan)
>+            scrollingTree->setCanRubberBandState(canRubberBandAtLeft, canRubberBandAtRight, canRubberBandAtTop, canRubberBandAtBottom);
> 
>         ScrollingTree::EventResult result = scrollingTree->tryToHandleWheelEvent(platformWheelEvent);
>

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188894: 347941