Attachment 347937 Details for Bug 188801 – Patch

[patch] Patch

bug-188801-20180823120023.patch (text/plain), 2.79 KB, created by Devin Rousso on 2018-08-23 11:00:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-08-23 11:00:25 PDT

Size: 2.79 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index dd6b865b5b6a7275b52d2cab410b6e4acb6b6327..d242bbbe58acb7b90076dcd2632829d293121f88 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-08-23  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: `console.inspect(sessionStorage)` first time does not show Session Storage content view if Storage tab was previously unvisited
>+        https://bugs.webkit.org/show_bug.cgi?id=188801
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Main.js:
>+        (WI.tabContentViewClassForRepresentedObject):
>+        (WI._storageWasInspected):
>+        Since the `WI.StorageSidebarPanel` is not created until the `WI.StorageTabContentView` is
>+        created, the `WI.StorageManager.Event.DOMStorageObjectWasInspected` and
>+        `WI.StorageManager.Event.DatabaseWasInspected` events do not reach the sidebar. We should
>+        follow what `WI._domNodeWasInspected` does and additionally call `WI.showRepresentedObject`
>+        on the inspected object.
>+
> 2018-08-21  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Remove TreeOutlineDataGridSynchronizer
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index cd2e8a526e71d119fa5ed53782cf65a3330c6d08..bc81d9d90bf4a5f1d6cc0e1d1448663a44e51305 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -1121,12 +1121,11 @@ WI.tabContentViewClassForRepresentedObject = function(representedObject)
>         || (representedObject instanceof WI.Collection && !(representedObject instanceof WI.CanvasCollection)))
>         return WI.ResourcesTabContentView;
> 
>-    // FIXME: Move these to a Storage tab.
>     if (representedObject instanceof WI.DOMStorageObject || representedObject instanceof WI.CookieStorageObject ||
>         representedObject instanceof WI.DatabaseTableObject || representedObject instanceof WI.DatabaseObject ||
>         representedObject instanceof WI.ApplicationCacheFrame || representedObject instanceof WI.IndexedDatabaseObjectStore ||
>-        representedObject instanceof WI.IndexedDatabaseObjectStoreIndex)
>-        return WI.ResourcesTabContentView;
>+        representedObject instanceof WI.IndexedDatabase || representedObject instanceof WI.IndexedDatabaseObjectStoreIndex)
>+        return WI.StorageTabContentView;
> 
>     if (representedObject instanceof WI.CanvasCollection)
>         return WI.CanvasTabContentView;
>@@ -1815,6 +1814,7 @@ WI._moveWindowMouseDown = function(event)
> WI._storageWasInspected = function(event)
> {
>     this.showStorageTab();
>+    this.showRepresentedObject(event.data.domStorage, null, {ignoreSearchTab: true});
> };
> 
> WI._domNodeWasInspected = function(event)

Actions: View | Formatted Diff | Diff

Attachments on bug 188801: 347937