Attachment 347934 Details for Bug 188891 – Patch

[patch] Patch

bug-188891-20180823104100.patch (text/plain), 2.19 KB, created by Timothy Hatcher on 2018-08-23 10:41:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-08-23 10:41:00 PDT

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 235229
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 05f2ae20c465e48d0a513c55f76a42ce07678768..6e256f1fb74389e04d99b2f9f809970f03286436 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-23  Timothy Hatcher  <timothy@apple.com>
>+
>+        REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
>+        https://bugs.webkit.org/show_bug.cgi?id=188891
>+        rdar://problem/42344352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
>+        Don't return early when m_layerForOverhangAreas is null to avoid skipping
>+        setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().
>+
> 2018-08-23  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Attachment Support] Attachment elements don't appear in drag images on macOS
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index 5b3ab98f0f0c11a4ea24f36623800a10add19ba0..7455255f050418db3d6c589f055c4af53fee9341 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -3221,13 +3221,12 @@ void RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged()
>         page().chrome().client().pageExtendedBackgroundColorDidChange(m_rootExtendedBackgroundColor);
>         
> #if ENABLE(RUBBER_BANDING)
>-        if (!m_layerForOverhangAreas)
>-            return;
>-        
>-        m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
>-        
>-        if (!m_rootExtendedBackgroundColor.isValid())
>-            m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
>+        if (m_layerForOverhangAreas) {
>+            m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
>+
>+            if (!m_rootExtendedBackgroundColor.isValid())
>+                m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
>+        }
> #endif
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188891: 347934