Attachment 347928 Details for Bug 188888 – Patch

[patch] Patch

bug-188888-20180823094951.patch (text/plain), 4.16 KB, created by Ryan Haddad on 2018-08-23 09:49:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan Haddad

Created: 2018-08-23 09:49:52 PDT

Size: 4.16 KB

patch

obsolete

>Subversion Revision: 235225
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 51bfbdad17960e9460893fc02de1c30da096a6be..8b94ec497c9aaebf351348f9409a58252132741c 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-23  Ryan Haddad  <ryanhaddad@apple.com>
>+
>+        Update iOS selection tests to reflect new behavior introduced by r235153
>+        https://bugs.webkit.org/show_bug.cgi?id=188888
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html:
>+        * fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html:
>+        * fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:
>+
> 2018-08-22  John Wilander  <wilander@apple.com>
> 
>         Further adjustments to http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
>diff --git a/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html b/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html
>index fb3cd03aaaafbb64fe7d9e720bd3968bedb9221d..f9ce1a0ca671fb98bf656f995dcc5908f62af045 100644
>--- a/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html
>+++ b/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html
>@@ -76,7 +76,7 @@
>             output += '<br>';
> 
>             var result = await touchAndDragFromPointToPoint(dragX, dragY, dragX, dragY4);
>-            if (document.getSelection().toString() == "s")
>+            if (document.getSelection().toString() == "sed")
>                 output += 'PASS: Correct Selection';
>             else
>                 output += 'FAIL: failed to reduce selection to a single character by dragging up. Incorrect Selection: ' + document.getSelection().toString();
>diff --git a/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html b/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html
>index d66acd460f6241397c8a3ccceaa1fe1ed0aa7aa1..c403f25066d2f8d0faa8c52c90374bbd4eac3875 100644
>--- a/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html
>+++ b/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html
>@@ -76,7 +76,7 @@
>             output += '<br>';
> 
>             var result = await touchAndDragFromPointToPoint(dragX, dragY, dragX, dragY4);
>-            if (document.getSelection().toString() == "t")
>+            if (document.getSelection().toString() == "at")
>                 output += 'PASS: Correct Selection';
>             else
>                 output += 'FAIL: failed to reduce selection to a single character by dragging down. Incorrect Selection: ' + document.getSelection().toString();
>diff --git a/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html b/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html
>index 893a4c720ff44fb770306752cc2e97f9030f03a3..122f8add4b226d335f4dfcfb722f4a18f21018d7 100644
>--- a/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html
>+++ b/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html
>@@ -65,7 +65,7 @@
>             output += '<br>';
> 
>             var result = await touchAndDragFromPointToPoint(dragX, dragY, dragX, dragY4);
>-            if (document.getSelection().toString() == "t")
>+            if (document.getSelection().toString() == "ut")
>                 output += 'PASS: Correct Selection';
>             else
>                 output += 'FAIL: failed to reduce selection to a single character by dragging down. Incorrect Selection: ' + document.getSelection().toString();

Actions: View | Formatted Diff | Diff

Attachments on bug 188888: 347928