Attachment 347854 Details for Bug 188856 – Patch for landing

[patch] Patch for landing

bug-188856-20180822153009.patch (text/plain), 3.20 KB, created by John Wilander on 2018-08-22 15:30:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Wilander

Created: 2018-08-22 15:30:10 PDT

Size: 3.20 KB

patch

obsolete

>Subversion Revision: 235203
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 55b90a3709ad5a1c614f05c0c4e1b0650e61f8e0..36d5d3ef3cca10ea58d48e29b4917bc6406dcd66 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-08-22  John Wilander  <wilander@apple.com>
>+
>+        Further adjustments to http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
>+        https://bugs.webkit.org/show_bug.cgi?id=188856
>+
>+        Unreviewed test gardening. Trying to address flakiness I can't reproduce locally.
>+
>+        * http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html:
>+
> 2018-08-22  Aditya Keerthi  <akeerthi@apple.com>
> 
>         [iOS] Add support for the inputmode attribute
>diff --git a/LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html b/LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
>index b3a8aa6e00bdd5c0ee223b42d473e7666c186300..b2b0a92c31163029a35174e3d1e50a200329dd28 100644
>--- a/LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
>+++ b/LayoutTests/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
>@@ -9,12 +9,22 @@
> 
>     window.jsTestIsAsync = true;
> 
>+    const numberOfNotificationsExpected = 2;
>+    let numberOfNotificationsReceived = 0;
>     function completeTest() {
>-        if (testRunner.isStatisticsRegisteredAsSubresourceUnder("http://localhost", "http://127.0.0.1"))
>+        numberOfNotificationsReceived++;
>+        if (testRunner.isStatisticsRegisteredAsSubresourceUnder("http://localhost", "http://127.0.0.1")) {
>             testPassed("localhost registered as subresource under 127.0.0.1.");
>-        else
>-            testFailed("localhost not registered as subresource under 127.0.0.1.");
>-        setEnableFeature(false, finishJSTest);
>+            setEnableFeature(false, finishJSTest);
>+        } else {
>+            if (numberOfNotificationsReceived >= numberOfNotificationsExpected) {
>+                testFailed("localhost not registered as subresource under 127.0.0.1.");
>+                setEnableFeature(false, finishJSTest);
>+            } else {
>+                testRunner.installStatisticsDidScanDataRecordsCallback(completeTest);
>+                testRunner.statisticsNotifyObserver();
>+            }
>+        }
>     }
> 
>     function runTest() {
>@@ -22,13 +32,13 @@
>             if (testRunner.isStatisticsRegisteredAsSubresourceUnder("http://localhost", "http://127.0.0.1"))
>                 testFailed("localhost already registered as subresource under 127.0.0.1.");
> 
>-            testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true);
>-            testRunner.installStatisticsDidScanDataRecordsCallback(completeTest);
>-
>             let iframeElement = document.createElement("iframe");
>             iframeElement.src = "resources/localhost-websocket-connect.html";
>             iframeElement.id = "testIframe";
>             document.body.appendChild(iframeElement);
>+
>+            testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned(true);
>+            testRunner.installStatisticsDidScanDataRecordsCallback(completeTest);
>         });
>     }
> </script>

Actions: View | Formatted Diff | Diff

Attachments on bug 188856: 347819 | 347822 | 347828 | 347854