Attachment 347833 Details for Bug 188859 – Patch for landing

[patch] Patch for landing

188859.patch (text/plain), 3.07 KB, created by Michael Saboff on 2018-08-22 13:02:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2018-08-22 13:02:52 PDT

Size: 3.07 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 235190)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-22  Michael Saboff  <msaboff@apple.com>
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=188859
>+        Eliminate dead code operationThrowDivideError() and operationThrowOutOfBoundsAccessError()
>+
>+        Rubber-stamped by Saam Barati.
>+
>+        Deleted these two functions.
>+
>+        * jit/JITOperations.cpp:
>+        * jit/JITOperations.h:
>+
> 2018-08-22  Mark Lam  <mark.lam@apple.com>
> 
>         The DFG CFGSimplification phase shouldnât jettison a block when itâs the target of both branch directions.
>Index: Source/JavaScriptCore/jit/JITOperations.cpp
>===================================================================
>--- Source/JavaScriptCore/jit/JITOperations.cpp	(revision 235190)
>+++ Source/JavaScriptCore/jit/JITOperations.cpp	(working copy)
>@@ -114,34 +114,6 @@ void JIT_OPERATION operationThrowStackOv
>     throwStackOverflowError(callerFrame, scope);
> }
> 
>-#if ENABLE(WEBASSEMBLY)
>-void JIT_OPERATION operationThrowDivideError(ExecState* exec)
>-{
>-    VM* vm = &exec->vm();
>-    auto scope = DECLARE_THROW_SCOPE(*vm);
>-
>-    EntryFrame* entryFrame = vm->topEntryFrame;
>-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
>-
>-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
>-    ErrorHandlingScope errorScope(*vm);
>-    throwException(callerFrame, scope, createError(callerFrame, "Division by zero or division overflow."_s));
>-}
>-
>-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState* exec)
>-{
>-    VM* vm = &exec->vm();
>-    auto scope = DECLARE_THROW_SCOPE(*vm);
>-
>-    EntryFrame* entryFrame = vm->topEntryFrame;
>-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
>-
>-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
>-    ErrorHandlingScope errorScope(*vm);
>-    throwException(callerFrame, scope, createError(callerFrame, "Out-of-bounds access."_s));
>-}
>-#endif
>-
> int32_t JIT_OPERATION operationCallArityCheck(ExecState* exec)
> {
>     VM* vm = &exec->vm();
>Index: Source/JavaScriptCore/jit/JITOperations.h
>===================================================================
>--- Source/JavaScriptCore/jit/JITOperations.h	(revision 235190)
>+++ Source/JavaScriptCore/jit/JITOperations.h	(working copy)
>@@ -353,10 +353,6 @@ void JIT_OPERATION lookupExceptionHandle
> void JIT_OPERATION operationVMHandleException(ExecState*) WTF_INTERNAL;
> 
> void JIT_OPERATION operationThrowStackOverflowError(ExecState*, CodeBlock*) WTF_INTERNAL;
>-#if ENABLE(WEBASSEMBLY)
>-void JIT_OPERATION operationThrowDivideError(ExecState*) WTF_INTERNAL;
>-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState*) WTF_INTERNAL;
>-#endif
> int32_t JIT_OPERATION operationCallArityCheck(ExecState*) WTF_INTERNAL;
> int32_t JIT_OPERATION operationConstructArityCheck(ExecState*) WTF_INTERNAL;
> EncodedJSValue JIT_OPERATION operationTryGetById(ExecState*, StructureStubInfo*, EncodedJSValue, UniquedStringImpl*) WTF_INTERNAL;

Actions: View | Formatted Diff | Diff

Attachments on bug 188859: 347833