Attachment 347821 Details for Bug 188854 – Patch

[patch] Patch

bug-188854-20180822111000.patch (text/plain), 2.84 KB, created by Eric Carlson on 2018-08-22 11:10:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-08-22 11:10:02 PDT

Size: 2.84 KB

patch

obsolete

>Subversion Revision: 235110
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 67ce640d4aef7339fddccf59205b71a98300fcdd..5f7975c63170c70e323e4062bc51ca6326ea2173 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-22  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Log more often during AirPlay state changes
>+        https://bugs.webkit.org/show_bug.cgi?id=188854
>+
>+        Always log some infrequent but important AirPlay state changes to make debugging easier.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * html/HTMLMediaElement.cpp:
>+        (WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Low always.
>+        (WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Ditto.
>+        (WebCore::HTMLMediaElement::setWirelessPlaybackTarget): Ditto.
>+        (WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget): Ditto.
>+
> 2018-08-21  Philippe Normand  <philn@igalia.com>
> 
>         [GStreamer][MSE] Generic main thread notification support
>diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp
>index 3588a72aac73c29990231ca981eb0776e2317d3a..3019e096b693d58eaa54e6af66ceab91ce5be5db 100644
>--- a/Source/WebCore/html/HTMLMediaElement.cpp
>+++ b/Source/WebCore/html/HTMLMediaElement.cpp
>@@ -5738,7 +5738,7 @@ void HTMLMediaElement::syncTextTrackBounds()
> #if ENABLE(WIRELESS_PLAYBACK_TARGET)
> void HTMLMediaElement::webkitShowPlaybackTargetPicker()
> {
>-    INFO_LOG(LOGIDENTIFIER);
>+    ALWAYS_LOG(LOGIDENTIFIER);
>     if (processingUserGestureForMedia())
>         removeBehaviorsRestrictionsAfterFirstUserGesture();
>     m_mediaSession->showPlaybackTargetPicker();
>@@ -5758,7 +5758,7 @@ void HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged(MediaPl
> {
>     m_isPlayingToWirelessTarget = m_player && m_player->isCurrentPlaybackTargetWireless();
> 
>-    INFO_LOG(LOGIDENTIFIER, "webkitCurrentPlaybackTargetIsWireless = ", m_isPlayingToWirelessTarget);
>+    ALWAYS_LOG(LOGIDENTIFIER, m_isPlayingToWirelessTarget);
>     ASSERT(m_player);
>     configureMediaControls();
>     scheduleEvent(eventNames().webkitcurrentplaybacktargetiswirelesschangedEvent);
>@@ -5831,7 +5831,7 @@ void HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent()
> 
> void HTMLMediaElement::setWirelessPlaybackTarget(Ref<MediaPlaybackTarget>&& device)
> {
>-    INFO_LOG(LOGIDENTIFIER);
>+    ALWAYS_LOG(LOGIDENTIFIER);
>     if (m_player)
>         m_player->setWirelessPlaybackTarget(WTFMove(device));
> }
>@@ -5852,7 +5852,7 @@ bool HTMLMediaElement::isPlayingToWirelessPlaybackTarget() const
> 
> void HTMLMediaElement::setShouldPlayToPlaybackTarget(bool shouldPlay)
> {
>-    INFO_LOG(LOGIDENTIFIER, "shouldPlay = ", shouldPlay);
>+    ALWAYS_LOG(LOGIDENTIFIER, shouldPlay);
> 
>     if (m_player)
>         m_player->setShouldPlayToPlaybackTarget(shouldPlay);

Actions: View | Formatted Diff | Diff

Attachments on bug 188854: 347821