Attachment 347817 Details for Bug 188842 – Patch

[patch] Patch

bug-188842-20180822103951.patch (text/plain), 5.69 KB, created by youenn fablet on 2018-08-22 10:39:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-08-22 10:39:51 PDT

Size: 5.69 KB

patch

obsolete

>Subversion Revision: 235135
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1e9a303ead1a52d2a59928a2de9c6f75ae0fa280..29eed2e0624e0a99c03248454e01ae5557a3d189 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-22  Youenn Fablet  <youenn@apple.com>
>+
>+        self.isSecureContext undefined in Service Worker
>+        https://bugs.webkit.org/show_bug.cgi?id=188842
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable isSecureContext runtime flag.
>+
>+        * WebProcess/Storage/WebSWContextManagerConnection.cpp:
>+        (WebKit::WebSWContextManagerConnection::updatePreferencesStore):
>+
> 2018-08-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Increment NetworkCache::Storage::lastStableVersion after r233742
>diff --git a/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp b/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
>index c72b472e63fcb7b033ae335f585c327a2a5406f6..7e95aa5c9a507d3597335dd67b8b69d22e5d4321 100644
>--- a/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
>+++ b/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
>@@ -131,6 +131,7 @@ void WebSWContextManagerConnection::updatePreferencesStore(const WebPreferencesS
>     RuntimeEnabledFeatures::sharedFeatures().setFetchAPIKeepAliveEnabled(store.getBoolValueForKey(WebPreferencesKey::fetchAPIKeepAliveEnabledKey()));
>     RuntimeEnabledFeatures::sharedFeatures().setRestrictedHTTPResponseAccess(store.getBoolValueForKey(WebPreferencesKey::restrictedHTTPResponseAccessKey()));
>     RuntimeEnabledFeatures::sharedFeatures().setServerTimingEnabled(store.getBoolValueForKey(WebPreferencesKey::serverTimingEnabledKey()));
>+    RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(store.getBoolValueForKey(WebPreferencesKey::isSecureContextAttributeEnabledKey()));
> 
>     m_storageBlockingPolicy = static_cast<SecurityOrigin::StorageBlockingPolicy>(store.getUInt32ValueForKey(WebPreferencesKey::storageBlockingPolicyKey()));
> }
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 0e4dda7c09e4074dc99e534b7da895f504d9c327..43c5be6278167bd8ee6e0c07c58f4abed72b84f9 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-22  Youenn Fablet  <youenn@apple.com>
>+
>+        self.isSecureContext undefined in Service Worker
>+        https://bugs.webkit.org/show_bug.cgi?id=188842
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https-expected.txt: Added.
>+        * web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https.html: Added.
>+        * web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.serviceworker.js: Added.
>+        (test):
>+
> 2018-08-21  Youenn Fablet  <youenn@apple.com>
> 
>         Update libwebrtc up to 984f1a80c0
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..00ddc0f368d29ae0ff680cecca0e9e706ef25242
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https-expected.txt
>@@ -0,0 +1,4 @@
>+
>+PASS Setting up tests 
>+PASS isSecureContext 
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https.html b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..399820dd2c313b5023f63ea7846cc1f39fcbb1d6
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.https.html
>@@ -0,0 +1,32 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<title>Service Worker: isSecureContext</title>
>+</head>
>+<body>
>+<script src="/resources/testharness.js"></script>
>+<script src="/resources/testharnessreport.js"></script>
>+<script src="../resources/test-helpers.sub.js"></script>
>+<script>
>+'use strict';
>+
>+promise_test(async (t) => {
>+    var url = 'isSecureContext.serviceworker.js';
>+    var scope = 'empty.html';
>+    var frame_sw, sw_registration;
>+
>+    await service_worker_unregister(t, scope);
>+    var f = await with_iframe(scope);
>+    t.add_cleanup(function() {
>+        f.remove();
>+    });
>+    frame_sw = f.contentWindow.navigator.serviceWorker;
>+    var registration = await navigator.serviceWorker.register(url, {scope: scope});
>+    sw_registration = registration;
>+    await wait_for_state(t, registration.installing, 'activated');
>+    fetch_tests_from_worker(sw_registration.active);
>+}, 'Setting up tests');
>+
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.serviceworker.js b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.serviceworker.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..5033594e34ba75fa2d69b8d44c0cc69e333d3569
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.serviceworker.js
>@@ -0,0 +1,5 @@
>+importScripts("/resources/testharness.js");
>+
>+test(() => {
>+    assert_true(self.isSecureContext, true);
>+}, "isSecureContext");

Actions: View | Formatted Diff | Diff

Attachments on bug 188842: 347817