Attachment 347815 Details for Bug 188855 – Patch

[patch] Patch

bug-188855-20180822103049.patch (text/plain), 2.94 KB, created by Sihui Liu on 2018-08-22 10:30:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-22 10:30:49 PDT

Size: 2.94 KB

patch

obsolete

>Subversion Revision: 235143
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index fe4f30c091b3f68d6bdbf7ebf4de96a6379f6b8d..90faace7af0046dd7c30f29605d2f70460af8bcd 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-22  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Remove keys of defaults that are no longer used in webProcessPool
>+        https://bugs.webkit.org/show_bug.cgi?id=188855
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
>+        (WebKit::registerUserDefaultsIfNeeded):
>+
> 2018-08-21  Megan Gardner  <megan_gardner@apple.com>
> 
>         Use VisiblePosition to calculate selection ranges
>diff --git a/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm b/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>index 232273f7655e0cc538b95bd57cedf23d698319a6..97783d54785e9186711b1aa8c9c9a3519ca49c33 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>@@ -75,13 +75,9 @@ NSString *WebKitMediaCacheDirectoryDefaultsKey = @"WebKitMediaCacheDirectory";
> static NSString *WebKitApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification = @"NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification";
> #endif
> 
>-// FIXME: <rdar://problem/9138817> - After this "backwards compatibility" radar is removed, this code should be removed to only return an empty String.
>-NSString *WebIconDatabaseDirectoryDefaultsKey = @"WebIconDatabaseDirectoryDefaultsKey";
>-
> static NSString * const WebKit2HTTPProxyDefaultsKey = @"WebKit2HTTPProxy";
> static NSString * const WebKit2HTTPSProxyDefaultsKey = @"WebKit2HTTPSProxy";
> 
>-static NSString * const WebKitNetworkCacheEnabledDefaultsKey = @"WebKitNetworkCacheEnabled";
> static NSString * const WebKitNetworkCacheEfficacyLoggingEnabledDefaultsKey = @"WebKitNetworkCacheEfficacyLoggingEnabled";
> 
> static NSString * const WebKitSuppressMemoryPressureHandlerDefaultsKey = @"WebKitSuppressMemoryPressureHandler";
>@@ -98,9 +94,6 @@ static NSString * const WebKitRecordReplayCacheLocationDefaultsKey = @"WebKitRec
> 
> namespace WebKit {
> 
>-NSString *SchemeForCustomProtocolRegisteredNotificationName = @"WebKitSchemeForCustomProtocolRegisteredNotification";
>-NSString *SchemeForCustomProtocolUnregisteredNotificationName = @"WebKitSchemeForCustomProtocolUnregisteredNotification";
>-
> static void registerUserDefaultsIfNeeded()
> {
>     static bool didRegister;
>@@ -113,7 +106,6 @@ static void registerUserDefaultsIfNeeded()
>     [registrationDictionary setObject:@YES forKey:WebKitJSCJITEnabledDefaultsKey];
>     [registrationDictionary setObject:@YES forKey:WebKitJSCFTLJITEnabledDefaultsKey];
> 
>-    [registrationDictionary setObject:@YES forKey:WebKitNetworkCacheEnabledDefaultsKey];
>     [registrationDictionary setObject:@NO forKey:WebKitNetworkCacheEfficacyLoggingEnabledDefaultsKey];
> 
>     [[NSUserDefaults standardUserDefaults] registerDefaults:registrationDictionary];

Actions: View | Formatted Diff | Diff

Attachments on bug 188855: 347815