Attachment 347799 Details for Bug 188849 – Patch

[patch] Patch

bug-188849-20180822175612.patch (text/plain), 8.54 KB, created by Zan Dobersek on 2018-08-22 08:56:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-08-22 08:56:13 PDT

Size: 8.54 KB

patch

obsolete

>Subversion Revision: 235165
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 10922dc9633b88dd43b463f74641a3cbb52852c1..1580c54773badc4ee875b17d78f0b07b46b6c1d3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,30 @@
>+2018-08-22  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [CoordGraphics] Remove TiledBackingStoreClient inheritance from CoordinatedGraphicsLayer
>+        https://bugs.webkit.org/show_bug.cgi?id=188849
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove the TiledBackingStoreClient inheritance from the
>+        CoordinatedGraphicsLayer class since it's not used anymore after changes
>+        made in r235165.
>+
>+        Related TiledBackingStore objects on this class, along with tile state
>+        tracking member variables on the CoordinatedGraphicsLayerState class,
>+        are also removed.
>+
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
>+        (WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
>+        (WebCore::CoordinatedGraphicsLayer::resetLayerState):
>+        (WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
>+        (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreHasPendingTileCreation): Deleted.
>+        (WebCore::CoordinatedGraphicsLayer::createTile): Deleted.
>+        (WebCore::CoordinatedGraphicsLayer::updateTile): Deleted.
>+        (WebCore::CoordinatedGraphicsLayer::removeTile): Deleted.
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
>+        (WebCore::CoordinatedGraphicsLayerState::hasPendingChanges const):
>+
> 2018-08-22  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [CoordGraphics] Switch to Nicosia::CompositionLayer state tracking
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>index 59db0f592ad8bb9496412fb9846fdb6cce3f81e6..ad65c7bc184f830e65152112fbab398d5cd75a57 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>@@ -38,6 +38,7 @@
> #include "NicosiaPaintingEngine.h"
> #include "ScrollableArea.h"
> #include "TextureMapperPlatformLayerProxyProvider.h"
>+#include "TiledBackingStore.h"
> #ifndef NDEBUG
> #include <wtf/SetForScope.h>
> #endif
>@@ -163,7 +164,6 @@ CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer()
>         m_coordinator->detachLayer(this);
>     }
>     ASSERT(!m_coordinatedImageBacking);
>-    ASSERT(!m_mainBackingStore);
>     ASSERT(!m_nicosia.imageBacking);
>     ASSERT(!m_nicosia.backingStore);
>     willBeDestroyed();
>@@ -984,9 +984,6 @@ void CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers()
> void CoordinatedGraphicsLayer::resetLayerState()
> {
>     m_layerState.changeMask = 0;
>-    m_layerState.tilesToCreate.clear();
>-    m_layerState.tilesToRemove.clear();
>-    m_layerState.tilesToUpdate.clear();
> }
> 
> bool CoordinatedGraphicsLayer::imageBackingVisible()
>@@ -1018,12 +1015,6 @@ float CoordinatedGraphicsLayer::effectiveContentsScale()
>     return selfOrAncestorHaveNonAffineTransforms() ? 1 : deviceScaleFactor() * pageScaleFactor();
> }
> 
>-void CoordinatedGraphicsLayer::tiledBackingStoreHasPendingTileCreation()
>-{
>-    setNeedsVisibleRectAdjustment();
>-    notifyFlushRequired();
>-}
>-
> static void clampToContentsRectIfRectIsInfinite(FloatRect& rect, const FloatSize& contentsSize)
> {
>     if (rect.width() >= LayoutUnit::nearlyMax() || rect.width() <= LayoutUnit::nearlyMin()) {
>@@ -1052,36 +1043,6 @@ IntRect CoordinatedGraphicsLayer::transformedVisibleRect()
>     return enclosingIntRect(rect);
> }
> 
>-void CoordinatedGraphicsLayer::createTile(uint32_t tileID, float scaleFactor)
>-{
>-    ASSERT(m_coordinator);
>-    ASSERT(m_coordinator->isFlushingLayerChanges());
>-
>-    TileCreationInfo creationInfo;
>-    creationInfo.tileID = tileID;
>-    creationInfo.scale = scaleFactor;
>-    m_layerState.tilesToCreate.append(creationInfo);
>-}
>-
>-void CoordinatedGraphicsLayer::updateTile(uint32_t tileID, const SurfaceUpdateInfo& updateInfo, const IntRect& tileRect)
>-{
>-    ASSERT(m_coordinator);
>-    ASSERT(m_coordinator->isFlushingLayerChanges());
>-
>-    TileUpdateInfo tileUpdateInfo;
>-    tileUpdateInfo.tileID = tileID;
>-    tileUpdateInfo.tileRect = tileRect;
>-    tileUpdateInfo.updateInfo = updateInfo;
>-    m_layerState.tilesToUpdate.append(tileUpdateInfo);
>-}
>-
>-void CoordinatedGraphicsLayer::removeTile(uint32_t tileID)
>-{
>-    ASSERT(m_coordinator);
>-    ASSERT(m_coordinator->isFlushingLayerChanges() || m_isPurging);
>-    m_layerState.tilesToRemove.append(tileID);
>-}
>-
> void CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayers()
> {
>     if (CoordinatedGraphicsLayer* mask = downcast<CoordinatedGraphicsLayer>(maskLayer()))
>@@ -1213,8 +1174,6 @@ void CoordinatedGraphicsLayer::purgeBackingStores()
> #ifndef NDEBUG
>     SetForScope<bool> updateModeProtector(m_isPurging, true);
> #endif
>-    m_mainBackingStore = nullptr;
>-    m_previousBackingStore = nullptr;
>     if (m_nicosia.backingStore) {
>         auto& layerState = downcast<Nicosia::BackingStoreTextureMapperImpl>(m_nicosia.backingStore->impl()).layerState();
>         layerState.isPurging = true;
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
>index 7d6b66db3d2e19adc3e66c3da947112b8c894746..f69da0677a387360ac20b2e32403abc6552f5d6d 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
>@@ -33,8 +33,6 @@
> #include "NicosiaBuffer.h"
> #include "NicosiaPlatformLayer.h"
> #include "TextureMapperAnimation.h"
>-#include "TiledBackingStore.h"
>-#include "TiledBackingStoreClient.h"
> #include "TransformationMatrix.h"
> #include <wtf/text/StringHash.h>
> 
>@@ -59,7 +57,6 @@ public:
> };
> 
> class WEBCORE_EXPORT CoordinatedGraphicsLayer : public GraphicsLayer
>-    , public TiledBackingStoreClient
>     , public CoordinatedImageBacking::Host {
> public:
>     explicit CoordinatedGraphicsLayer(Type, GraphicsLayerClient&);
>@@ -122,12 +119,6 @@ public:
> 
>     IntRect transformedVisibleRect();
> 
>-    // TiledBackingStoreClient
>-    void tiledBackingStoreHasPendingTileCreation() override;
>-    void createTile(uint32_t tileID, float) override;
>-    void updateTile(uint32_t tileID, const SurfaceUpdateInfo&, const IntRect&) override;
>-    void removeTile(uint32_t tileID) override;
>-
>     void setCoordinator(CoordinatedGraphicsLayerClient*);
>     void setCoordinatorIncludingSubLayersIfNeeded(CoordinatedGraphicsLayerClient*);
> 
>@@ -207,8 +198,6 @@ private:
> #endif
> 
>     CoordinatedGraphicsLayerClient* m_coordinator;
>-    std::unique_ptr<TiledBackingStore> m_mainBackingStore;
>-    std::unique_ptr<TiledBackingStore> m_previousBackingStore;
> 
>     struct {
>         bool completeLayer { false };
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h
>index 6f9624f4e5d4b101c2ee611113e19d987b6e499b..206205a9fd188bdc4092c2969ced8aad365e9606 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h
>@@ -55,17 +55,6 @@ enum { InvalidCoordinatedLayerID = 0 };
> typedef uint64_t CoordinatedImageBackingID;
> enum { InvalidCoordinatedImageBackingID = 0 };
> 
>-struct TileUpdateInfo {
>-    uint32_t tileID;
>-    IntRect tileRect;
>-    WebCore::SurfaceUpdateInfo updateInfo;
>-};
>-
>-struct TileCreationInfo {
>-    uint32_t tileID;
>-    float scale;
>-};
>-
> struct DebugVisuals {
>     Color debugBorderColor;
>     float debugBorderWidth { 0 };
>@@ -150,23 +139,19 @@ struct CoordinatedGraphicsLayerState {
>     FilterOperations filters;
>     TextureMapperAnimations animations;
>     Vector<uint32_t> children;
>-    Vector<TileCreationInfo> tilesToCreate;
>-    Vector<uint32_t> tilesToRemove;
>     CoordinatedLayerID replica;
>     CoordinatedLayerID mask;
>     CoordinatedImageBackingID imageID;
>     DebugVisuals debugVisuals;
>     RepaintCount repaintCount;
> 
>-    Vector<TileUpdateInfo> tilesToUpdate;
>-
> #if USE(COORDINATED_GRAPHICS_THREADED)
>     RefPtr<TextureMapperPlatformLayerProxy> platformLayerProxy;
> #endif
> 
>     bool hasPendingChanges() const
>     {
>-        return changeMask || tilesToUpdate.size() || tilesToRemove.size() || tilesToCreate.size();
>+        return changeMask;
>     }
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188849: 347799 | 347905