Attachment 347778 Details for Bug 188802 – Patch

[patch] Patch

bug-188802-20180822135857.patch (text/plain), 6.21 KB, created by Rob Buis on 2018-08-22 04:58:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-08-22 04:58:59 PDT

Size: 6.21 KB

patch

obsolete

>Subversion Revision: 235090
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 39fa429adf4e06361a0d19b5bbd907ac70bf5d27..b3a1ede78f04c27eecaa95e5f953059a5dacb735 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-08-22  Rob Buis  <rbuis@igalia.com>
>+
>+        Fetch: Stop checking Request.integrity's value in no-cors mode
>+        https://bugs.webkit.org/show_bug.cgi?id=188802
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove this check since it was removed from the spec.
>+
>+        Behavior matches Chrome and Firefox.
>+
>+        Test: http/tests/subresource-integrity/sri-fetch.js:
>+
>+        * Modules/fetch/FetchRequest.cpp:
>+        (WebCore::FetchRequest::initializeOptions):
>+
> 2018-08-20  Jeremy Jones  <jeremyj@apple.com>
> 
>         UIWebView crashes while attempting to play youtube video on phone
>diff --git a/Source/WebCore/Modules/fetch/FetchRequest.cpp b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>index 5398aede7d2d6353db27cb5181a42f57ebda61b1..c37ac6923f320f03ae24948e7bd473aeab890bda 100644
>--- a/Source/WebCore/Modules/fetch/FetchRequest.cpp
>+++ b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>@@ -134,8 +134,6 @@ ExceptionOr<void> FetchRequest::initializeOptions(const Init& init)
>         const String& method = m_request.httpMethod();
>         if (method != "GET" && method != "POST" && method != "HEAD")
>             return Exception { TypeError, "Method must be GET, POST or HEAD in no-cors mode."_s };
>-        if (!m_options.integrity.isEmpty())
>-            return Exception { TypeError, "There cannot be an integrity in no-cors mode."_s };
>         m_headers->setGuard(FetchHeaders::Guard::RequestNoCors);
>     }
>     
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 924066c7a4225e2ec8ae1a8dafa9dd30acc95a86..f05232186e9a61f26888e017e4323e441fb24b93 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-22  Rob Buis  <rbuis@igalia.com>
>+
>+        Fetch: Stop checking Request.integrity's value in no-cors mode
>+        https://bugs.webkit.org/show_bug.cgi?id=188802
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unskip fetch/api/basic/integrity.html and adjust sri-fetch.js.
>+
>+        * TestExpectations:
>+        * http/tests/subresource-integrity/sri-fetch.js:
>+
> 2018-08-20  Justin Fan  <justin_fan@apple.com>
> 
>         Update webkit-webgl-test-harness.js to provide more info on failing and partially passing tests
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index e25f6fdc649482ff5a4d4b9272210f9b9ee2a962..0a50a3a6f5aefb85663853a0e860c2cbf08d72fc 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-22  Rob Buis  <rbuis@igalia.com>
>+
>+        Fetch: Stop checking Request.integrity's value in no-cors mode
>+        https://bugs.webkit.org/show_bug.cgi?id=188802
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update integrity.html expected result.
>+
>+        * web-platform-tests/fetch/api/basic/integrity-expected.txt:
>+
> 2018-08-20  Rob Buis  <rbuis@igalia.com>
> 
>         Throw an exception if window.open() gets passed a URL that cannot be parsed
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index e180442c05907687f7c0187ef9087d900719ac79..0cf79f22aac1c0553ab90dffe3ad21a595283b22 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -707,9 +707,6 @@ webkit.org/b/171511 http/wpt/resource-timing/rt-revalidate-requests.html [ Pass
> 
> webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
> 
>-webkit.org/b/178241 imported/w3c/web-platform-tests/fetch/api/basic/integrity.html [ Pass Failure ]
>-webkit.org/b/178241 imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html [ Pass Failure ]
>-
> imported/w3c/web-platform-tests/fetch/http-cache/partial.html [ Failure Pass ]
> webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]
> 
>diff --git a/LayoutTests/http/tests/subresource-integrity/sri-fetch.js b/LayoutTests/http/tests/subresource-integrity/sri-fetch.js
>index db80eda5548a819adb77449492fcce3a70f9604d..c7f98d044c907cfa23610f60a75da14538499336 100644
>--- a/LayoutTests/http/tests/subresource-integrity/sri-fetch.js
>+++ b/LayoutTests/http/tests/subresource-integrity/sri-fetch.js
>@@ -59,7 +59,7 @@ integrity("Credential CORS invalid integrity", crossorigin_creds_resource, { 'in
> integrity("Ineligible CORS empty integrity", crossorigin_ineligible_resource, { 'integrity': "" }, new TypeError());
> integrity("Ineligible CORS SHA-512 integrity", crossorigin_ineligible_resource, { 'integrity': topSha512 }, new TypeError());
> integrity("Ineligible CORS invalid integrity", crossorigin_ineligible_resource, { 'integrity': invalidSha512 }, new TypeError());
>-integrity("SHA-256 integrity with 'no-cors' mode", resource, { 'integrity': topSha256, 'mode': 'no-cors' }, new TypeError());
>+integrity("SHA-256 integrity with 'no-cors' mode", resource, { 'integrity': topSha256, 'mode': 'no-cors' });
> integrity("Resource with zero length body", empty_resource, { 'integrity': "47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=" });
> 
> done();
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt
>index 60c9620ae92a5575f06494de8cb55347a37401a0..42e5fd830f4b55397995bb2a4619654af809edbc 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt
>@@ -2,6 +2,7 @@ CONSOLE MESSAGE: Fetch API cannot load http://localhost:8800/fetch/api/resources
> CONSOLE MESSAGE: Fetch API cannot load http://localhost:8800/fetch/api/resources/top.txt.
> CONSOLE MESSAGE: Fetch API cannot load http://localhost:8800/fetch/api/resources/top.txt.
> CONSOLE MESSAGE: Fetch API cannot load http://localhost:8801/fetch/api/resources/top.txt?pipe=header(Access-Control-Allow-Origin,*).
>+CONSOLE MESSAGE: Fetch API cannot load https://localhost:9443/fetch/api/resources/top.txt.
> 
> PASS Empty string integrity 
> PASS SHA-256 integrity

Actions: View | Formatted Diff | Diff

Attachments on bug 188802: 347671 | 347778