Attachment 347771 Details for Bug 188803 – Patch

[patch] Patch

bug-188803-20180821235021.patch (text/plain), 1.92 KB, created by Devin Rousso on 2018-08-21 23:50:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-08-21 23:50:21 PDT

Size: 1.92 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index dd6b865b5b6a7275b52d2cab410b6e4acb6b6327..5049aa1c8fab52948bfdc7cb09f2320d2c7025e0 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-21  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting delete
>+        https://bugs.webkit.org/show_bug.cgi?id=188803
>+        <rdar://problem/43572838>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DebuggerSidebarPanel.js:
>+        (WI.DebuggerSidebarPanel.prototype._domBreakpointAddedOrRemoved):
>+        (WI.DebuggerSidebarPanel.prototype._eventBreakpointAddedOrRemoved):
>+
> 2018-08-21  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Remove TreeOutlineDataGridSynchronizer
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>index 4e23315880b16df1eed2390a671986e64e51bb86..89e36231d3e7db43571db5b6e6a6cdfcfca6a8e3 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>@@ -1223,7 +1223,7 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSideba
>             return;
>         }
> 
>-        if (this._domBreakpointsContentTreeOutline.element.parent)
>+        if (this._domBreakpointsContentTreeOutline.element.parentNode)
>             return;
> 
>         this._domBreakpointsRow.hideEmptyMessage();
>@@ -1239,7 +1239,7 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSideba
>             return;
>         }
> 
>-        if (this._eventBreakpointsContentTreeOutline.element.parent)
>+        if (this._eventBreakpointsContentTreeOutline.element.parentNode)
>             return;
> 
>         this._eventBreakpointsRow.hideEmptyMessage();

Actions: View | Formatted Diff | Diff

Attachments on bug 188803: 347771