Attachment 347715 Details for Bug 188824 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

eslint-1.patch (text/plain), 26.14 KB, created by Joseph Pecoraro on 2018-08-21 15:41:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-08-21 15:41:46 PDT

Size: 26.14 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/.eslintrc b/Source/WebInspectorUI/.eslintrc
>index 21b73f51a07..5e6df599ede 100644
>--- a/Source/WebInspectorUI/.eslintrc
>+++ b/Source/WebInspectorUI/.eslintrc
>@@ -54,6 +54,7 @@
>         "RecordingAgent": true,
>         "RuntimeAgent": true,
>         "ScriptProfilerAgent": true,
>+        "ServiceWorkerAgent": true,
>         "TimelineAgent": true,
>         "WorkerAgent": true,
> 
>@@ -98,6 +99,7 @@
>         "CSSPrimitiveValue": true,
>         "Exception": true,
>         "WebKitPoint": true,
>+        "SQLError": true,
> 
>         // Utilities
>         "appendWebInspectorConsoleEvaluationSourceURL": true,
>@@ -122,6 +124,7 @@
>         "parseMIMEType": true,
>         "resolveDotsInPath": true,
>         "simpleGlobStringToRegExp": true,
>+        "textToBlob": true,
>         "timestamp": true,
>         "zeroWidthSpace": true,
> 
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 97038dbf32f..7c6730607f6 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,38 @@
>+2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Address some ESLint warnings
>+        https://bugs.webkit.org/show_bug.cgi?id=188824
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * .eslintrc:
>+        * UserInterface/Base/Platform.js:
>+        * UserInterface/Controllers/AuditManager.js:
>+        * UserInterface/Controllers/BasicBlockAnnotator.js:
>+        * UserInterface/Controllers/CallFrameTreeController.js:
>+        * UserInterface/Controllers/HARBuilder.js:
>+        * UserInterface/Models/AuditReport.js:
>+        * UserInterface/Models/AuditResult.js:
>+        * UserInterface/Models/AuditTestCase.js:
>+        * UserInterface/Models/AuditTestSuite.js:
>+        * UserInterface/Models/Cookie.js:
>+        * UserInterface/Models/SourceCodePosition.js:
>+        * UserInterface/Test/FrontendTestHarness.js:
>+        * UserInterface/Test/TestSuite.js:
>+        * UserInterface/Views/CanvasContentView.js:
>+        * UserInterface/Views/CollectionContentView.js:
>+        * UserInterface/Views/ContentBrowser.js:
>+        * UserInterface/Views/CookieStorageContentView.js:
>+        * UserInterface/Views/DataGrid.js:
>+        * UserInterface/Views/DatabaseTableContentView.js:
>+        * UserInterface/Views/FindBanner.js:
>+        * UserInterface/Views/JSONResourceContentView.js:
>+        * UserInterface/Views/LogContentView.js:
>+        * UserInterface/Views/ResourceSidebarPanel.js:
>+        * UserInterface/Views/SourceCodeTextEditor.js:
>+        * UserInterface/Views/SpreadsheetTextField.js:
>+        * UserInterface/Workers/Formatter/FormatterUtilities.js:
>+
> 2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: âG does not while find banner is focused
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Platform.js b/Source/WebInspectorUI/UserInterface/Base/Platform.js
>index c82e01238d0..4f2e1e7c093 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Platform.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Platform.js
>@@ -49,7 +49,7 @@ WI.Platform = {
>         WI.Platform.version.base = 10;
>         WI.Platform.version.release = parseInt(osVersionMatch[2]);
>         switch (osVersionMatch[2]) {
>-        case "12":
>+        case "13":
>             WI.Platform.version.name = "high-sierra";
>             break;
>         case "12":
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>index 52f68a0d709..5bdc42a0433 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>@@ -23,7 +23,7 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>- WI.AuditManager = class AuditManager extends WI.Object
>+WI.AuditManager = class AuditManager extends WI.Object
> {
>     constructor()
>     {
>@@ -31,12 +31,12 @@
> 
>         this._testSuiteConstructors = [];
>         this._reports = new Map;
>-        
>+
>         // Transforming all the constructors into AuditTestSuite instances.
>-        this._testSuites = this._testSuiteConstructors.map(suite =>  {
>+        this._testSuites = this._testSuiteConstructors.map(suite => {
>             let newTestSuite = new suite;
> 
>-            if (!newTestSuite instanceof WI.AuditTestSuite)
>+            if (!(newTestSuite instanceof WI.AuditTestSuite))
>                 throw new Error("Audit test suites must be of instance WI.AuditTestSuite.");
> 
>             return newTestSuite;
>@@ -56,11 +56,11 @@
>             let auditResult = await this._runTestCase(representedObject);
>             auditReport.addResult(auditResult);
>         } else if (representedObject instanceof WI.AuditTestSuite) {
>-            let testCases = representedObject.testCases;            
>+            let testCases = representedObject.testCases;
>             // Start reducing from testCases[0].
>             let result = testCases.slice(1).reduce((chain, testCase, index) => {
>                 if (testCase.setup) {
>-                    let setup = testCase.setup.call(testCase, testCase.suite)
>+                    let setup = testCase.setup.call(testCase, testCase.suite);
>                     if (testCase.setup[Symbol.toStringTag] === "AsyncFunction")
>                         return setup;
>                     else
>@@ -73,7 +73,7 @@
>                 });
> 
>                 if (testCase.tearDown) {
>-                    let tearDown = testCase.tearDown.call(testCase, testCase.suite)
>+                    let tearDown = testCase.tearDown.call(testCase, testCase.suite);
>                     if (testCase.tearDown[Symbol.toStringTag] === "AsyncFunction")
>                         return tearDown;
>                     else
>@@ -131,9 +131,9 @@
>         this.dispatchEventToListeners(WI.AuditManager.Event.TestEnded, {test: testCase});
>         return new WI.AuditResult(testCase, {result}, didRaiseException);
>     }
>-}
>+};
> 
> WI.AuditManager.Event = {
>     TestStarted: Symbol("test-started"),
>     TestEnded: Symbol("test-ended")
>-}
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/BasicBlockAnnotator.js b/Source/WebInspectorUI/UserInterface/Controllers/BasicBlockAnnotator.js
>index 9ca9a22ebbf..2bb0e045840 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/BasicBlockAnnotator.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/BasicBlockAnnotator.js
>@@ -63,7 +63,7 @@ WI.BasicBlockAnnotator = class BasicBlockAnnotator extends WI.Annotator
>         while (match) {
>             lineEndings.push(match.index);
>             lineEndingLengths.push(match[0].length);
>-            match = pattern.exec(content)
>+            match = pattern.exec(content);
>         }
> 
>         function offsetToPosition(offset) {
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js b/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js
>index 32d38810b60..4a3f210d11b 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js
>@@ -59,7 +59,7 @@ WI.CallFrameTreeController = class CallFrameTreeController extends WI.Object
>         this._treeOutline.removeChildren();
> 
>         for (let callFrame of this._callFrames)
>-            this._treeOutline.appendChild(new WI.CallFrameTreeElement(callFrame))
>+            this._treeOutline.appendChild(new WI.CallFrameTreeElement(callFrame));
>     }
> 
>     disconnect()
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js b/Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js
>index af6ea6a7564..6fbfe495263 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js
>@@ -308,4 +308,4 @@ WI.HARBuilder = class HARBuilder
>         console.assert(false);
>         return undefined;
>     }
>-}
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Models/AuditReport.js b/Source/WebInspectorUI/UserInterface/Models/AuditReport.js
>index 6cb83057e70..62ad09dde6b 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/AuditReport.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/AuditReport.js
>@@ -23,12 +23,12 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>- WI.AuditReport = class AuditReport
>+WI.AuditReport = class AuditReport
> {
>     constructor(representedTest)
>     {
>         console.assert(representedTest instanceof WI.AuditTestCase || representedTest instanceof WI.AuditTestSuite);
>-        
>+
>         this._results = [];
>         this._isWritable = true;
>         this._representedTestCases = (representedTest instanceof WI.AuditTestCase) ? [representedTest] : [...representedTest.testCases];
>@@ -59,4 +59,4 @@
>     {
>         this._isWritable = false;
>     }
>-}
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Models/AuditResult.js b/Source/WebInspectorUI/UserInterface/Models/AuditResult.js
>index ee9ba1baa6c..4663a20e04d 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/AuditResult.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/AuditResult.js
>@@ -23,7 +23,7 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>- WI.AuditResult = class AuditResult
>+WI.AuditResult = class AuditResult
> {
>     constructor(testInstance, testResult, failed)
>     {
>@@ -43,10 +43,10 @@
>     get name() { return this._testName; }
>     get logLevel() { return this._logLevel; }
>     get failed() { return this._failed; }
>-}
>+};
> 
> WI.AuditResult.LogLevel = {
>     Error: "error",
>     Warning: "warning",
>     Passed: "passed"
>-}
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js b/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js
>index 4547e243d9d..d73800d8e7c 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js
>@@ -23,13 +23,13 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>- WI.AuditTestCase = class AuditTestCase extends WI.Object
>+WI.AuditTestCase = class AuditTestCase extends WI.Object
> {
>     constructor(suite, name, test, setup, tearDown, errorDetails = {})
>     {
>         console.assert(suite instanceof WI.AuditTestSuite);
>-        console.assert(typeof(name) === "string");
>-        
>+        console.assert(typeof name === "string");
>+
>         if (setup)
>             console.assert(setup instanceof Function);
> 
>@@ -41,7 +41,7 @@
> 
>         super();
>         this._id = Symbol(name);
>-        
>+
>         this._suite = suite;
>         this._name = name;
>         this._test = test;
>@@ -59,4 +59,4 @@
>     get setup() { return this._setup; }
>     get tearDown() { return this._tearDown; }
>     get errorDetails() { return this._errorDetails; }
>-}
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Models/AuditTestSuite.js b/Source/WebInspectorUI/UserInterface/Models/AuditTestSuite.js
>index f073ef4ad17..52cfeaddd6d 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/AuditTestSuite.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/AuditTestSuite.js
>@@ -23,7 +23,7 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>- WI.AuditTestSuite = class AuditTestSuite extends WI.Object
>+WI.AuditTestSuite = class AuditTestSuite extends WI.Object
> {
>     constructor(identifier, name)
>     {
>@@ -50,12 +50,12 @@
>     _buildTestCasesFromDescriptors()
>     {
>         for (let descriptor of this.constructor.testCaseDescriptors()) {
>-            if (typeof(descriptor.name) !== "string" || !descriptor.name)
>+            if (typeof descriptor.name !== "string" || !descriptor.name)
>                 throw new Error("Test name must be a valid string.");
>-            
>+
>             let {name, test, setup, tearDown, errorDetails} = descriptor;
> 
>-            if (!test instanceof Function || test[Symbol.toStringTag] !== "AsyncFunction")
>+            if (!(test instanceof Function) || test[Symbol.toStringTag] !== "AsyncFunction")
>                 throw new Error("Test function must be an async function.");
> 
>             let testCaseInstance = new WI.AuditTestCase(this, name, test, setup, tearDown, errorDetails);
>@@ -63,8 +63,8 @@
>             this._testCases.set(testCaseInstance.id, testCaseInstance);
>         }
>     }
>-}
>+};
> 
> WI.AuditTestSuite.Event = {
>     NewAuditResultAvailable: Symbol("new-audit-result-available")
>-}   
>+};
>diff --git a/Source/WebInspectorUI/UserInterface/Models/Cookie.js b/Source/WebInspectorUI/UserInterface/Models/Cookie.js
>index cd2ad4e026e..46729426955 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/Cookie.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/Cookie.js
>@@ -214,7 +214,7 @@ WI.Cookie = class Cookie
> 
>         return new WI.Cookie(WI.Cookie.Type.Response, name, value, header, expires, maxAge, path, domain, secure, httpOnly, sameSite);
>     }
>-}
>+};
> 
> WI.Cookie.Type = {
>     Request: "request",
>diff --git a/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js b/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js
>index 7e3060f9f40..17a0a9f0069 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js
>@@ -42,12 +42,6 @@ WI.SourceCodePosition = class SourceCodePosition
>         return new WI.SourceCodePosition(this._lineNumber, this._columnNumber + delta);
>     }
> 
>-    offsetColumn(delta)
>-    {
>-        console.assert(this._columnNumber + delta >= 0);
>-        return new WI.SourceCodePosition(this._lineNumber, this._columnNumber + delta);
>-    }
>-
>     equals(position)
>     {
>         return this._lineNumber === position.lineNumber && this._columnNumber === position.columnNumber;
>diff --git a/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js b/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js
>index 023195f89f7..4fbf9a48273 100644
>--- a/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js
>+++ b/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js
>@@ -94,7 +94,7 @@ FrontendTestHarness = class FrontendTestHarness extends TestHarness
>             return (!remoteObjectOnly && remoteObject.hasValue()) ? remoteObject.value : remoteObject;
>         }
> 
>-        let response = RuntimeAgent.evaluate.invoke({expression, objectGroup: "test", includeCommandLineAPI: false})
>+        let response = RuntimeAgent.evaluate.invoke({expression, objectGroup: "test", includeCommandLineAPI: false});
>         if (callback && typeof callback === "function") {
>             response = response.then(({result, wasThrown}) => callback(null, translateResult(result), wasThrown));
>             response = response.catch((error) => callback(error, null, false));
>diff --git a/Source/WebInspectorUI/UserInterface/Test/TestSuite.js b/Source/WebInspectorUI/UserInterface/Test/TestSuite.js
>index 79ea5cbf6db..3e17fdf42a1 100644
>--- a/Source/WebInspectorUI/UserInterface/Test/TestSuite.js
>+++ b/Source/WebInspectorUI/UserInterface/Test/TestSuite.js
>@@ -182,7 +182,7 @@ SyncTestSuite = class SyncTestSuite extends TestSuite
>     addTestCase(testcase)
>     {
>         if ([testcase.setup, testcase.teardown, testcase.test].some((fn) => fn && fn[Symbol.toStringTag] === "AsyncFunction"))
>-            throw new Error("Tried to pass a test case with an async `setup`, `test`, or `teardown` function, but this is a synchronous test suite.")
>+            throw new Error("Tried to pass a test case with an async `setup`, `test`, or `teardown` function, but this is a synchronous test suite.");
> 
>         super.addTestCase(testcase);
>     }
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js b/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
>index 192267e1f9e..cee34bb8d18 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
>@@ -410,7 +410,7 @@ WI.CanvasContentView = class CanvasContentView extends WI.ContentView
>             let formatString = frameCount === 1 ? WI.UIString("%d Frame") : WI.UIString("%d Frames");
>             title = formatString.format(frameCount);
>         } else
>-            title = WI.UIString("Waiting for framesâ¦")
>+            title = WI.UIString("Waiting for framesâ¦");
> 
>         this._progressView.title = title;
>         this._progressView.subtitle = bufferUsed ? Number.bytesToString(bufferUsed) : "";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js b/Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js
>index a971659f889..110df7074b1 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js
>@@ -275,7 +275,7 @@ WI.CollectionContentView = class CollectionContentView extends WI.ContentView
>             if (typeof this._contentPlaceholder === "string")
>                 this._contentPlaceholderElement = WI.createMessageTextView(this._contentPlaceholder);
>             else if (this._contentPlaceholder instanceof HTMLElement)
>-                this._contentPlaceholderElement =  this._contentPlaceholder;
>+                this._contentPlaceholderElement = this._contentPlaceholder;
>         }
> 
>         if (!this._contentPlaceholderElement.parentNode)
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js b/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js
>index 1bfadab040e..35e7b5652e6 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js
>@@ -230,7 +230,7 @@ WI.ContentBrowser = class ContentBrowser extends WI.View
>     shown()
>     {
>         this._updateContentViewSelectionPathNavigationItem(this.currentContentView);
>-        this.updateHierarchicalPathForCurrentContentView()
>+        this.updateHierarchicalPathForCurrentContentView();
> 
>         this._contentViewContainer.shown();
>     }
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js b/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
>index 6cb92a881c4..0f6f62716fc 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js
>@@ -73,7 +73,7 @@ WI.CookieStorageContentView = class CookieStorageContentView extends WI.ContentV
>     {
>         // FIXME <https://webkit.org/b/151400>: If there are no cookies, add placeholder explanatory text.
>         if (!this._dataGrid) {
>-            var columns = {name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, http: {}, secure: {}, sameSite: {} };
>+            var columns = {name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, http: {}, secure: {}, sameSite: {}};
> 
>             columns.name.title = WI.UIString("Name");
>             columns.name.sortable = true;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
>index e2530f5512b..2e6421c1edc 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
>@@ -1573,7 +1573,6 @@ WI.DataGrid = class DataGrid extends WI.View
>         if (!gridNode) {
>             if (this.selectedNode)
>                 this.selectedNode.deselect();
>-            
>             return;
>         }
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js
>index 9037f6a587e..cb2b4c9c1be 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js
>@@ -69,7 +69,7 @@ WI.DatabaseTableContentView = class DatabaseTableContentView extends WI.ContentV
> 
>     _escapeTableName(name)
>     {
>-        return name.replace(/\"/g, "\"\"");
>+        return name.replace(/"/g, "\"\"");
>     }
> 
>     _queryFinished(columnNames, values)
>diff --git a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
>index b6981cf42b6..dc92c701abd 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
>@@ -53,7 +53,7 @@ WI.FindBanner = class FindBanner extends WI.NavigationItem
>         this._previousResultButton = document.createElement("button");
>         this._previousResultButton.classList.add("segmented", "previous-result");
>         this._previousResultButton.disabled = true;
>-        this._previousResultButton.title = WI.UIString("Find Previous (%s)").format(WI.findPreviousKeyboardShortcut.displayName);;
>+        this._previousResultButton.title = WI.UIString("Find Previous (%s)").format(WI.findPreviousKeyboardShortcut.displayName);
>         this._previousResultButton.addEventListener("click", this._previousResultButtonClicked.bind(this));
>         this.element.appendChild(this._previousResultButton);
> 
>@@ -64,7 +64,7 @@ WI.FindBanner = class FindBanner extends WI.NavigationItem
>         this._nextResultButton = document.createElement("button");
>         this._nextResultButton.classList.add("segmented", "next-result");
>         this._nextResultButton.disabled = true;
>-        this._nextResultButton.title = WI.UIString("Find Next (%s)").format(WI.findNextKeyboardShortcut.displayName);;
>+        this._nextResultButton.title = WI.UIString("Find Next (%s)").format(WI.findNextKeyboardShortcut.displayName);
>         this._nextResultButton.addEventListener("click", this._nextResultButtonClicked.bind(this));
>         this.element.appendChild(this._nextResultButton);
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>index 1bdd49cd80d..a78845c5d79 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>@@ -56,7 +56,7 @@ WI.JSONResourceContentView = class JSONResourceContentView extends WI.ResourceCo
>             doNotPauseOnExceptionsAndMuteConsole: true,
>             contextId: undefined,
>             returnByValue: false,
>-            generatePreview: true,    
>+            generatePreview: true,
>         };
>         this.resource.target.RuntimeAgent.evaluate.invoke(options, (error, result, wasThrown) => {
>             if (error || wasThrown) {
>@@ -80,6 +80,6 @@ WI.JSONResourceContentView = class JSONResourceContentView extends WI.ResourceCo
>         if (this._remoteObject) {
>             this._remoteObject.release();
>             this._remoteObject = null;
>-        }   
>+        }
>     }
> };
>diff --git a/Source/WebInspectorUI/UserInterface/Views/LogContentView.js b/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>index 3c86f9ee353..3d978755f61 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>@@ -79,7 +79,7 @@ WI.LogContentView = class LogContentView extends WI.ContentView
>             new WI.ScopeBarItem(WI.LogContentView.Scopes.Warnings, WI.UIString("Warnings"), false, "warnings"),
>             new WI.ScopeBarItem(WI.LogContentView.Scopes.Logs, WI.UIString("Logs"), false, "logs"),
>             new WI.ScopeBarItem(WI.LogContentView.Scopes.Infos, WI.UIString("Infos"), false, "infos", true),
>-            new WI.ScopeBarItem(WI.LogContentView.Scopes.Debugs, WI.UIString("Debugs"), false, "debugs", true),            
>+            new WI.ScopeBarItem(WI.LogContentView.Scopes.Debugs, WI.UIString("Debugs"), false, "debugs", true),
>         ];
> 
>         this._scopeBar = new WI.ScopeBar("log-scope-bar", scopeBarItems, scopeBarItems[0]);
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>index 5424eefab65..2f76b6cfec6 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>@@ -317,7 +317,7 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSideba
>                     this._addTargetWithMainResource(script.target);
>                 this.contentTreeOutline.disclosureButtons = true;
>                 return;
>-            }            
>+            }
>         }
> 
>         // If the script URL matches a resource we can assume it is part of that resource and does not need added.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>index 83d0ff1b590..12e5de2d511 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>@@ -1432,7 +1432,7 @@ WI.SourceCodeTextEditor = class SourceCodeTextEditor extends WI.TextEditor
>             startPosition = fromInlineScriptPosition(startPosition).toCodeMirror();
>             endPosition = fromInlineScriptPosition(endPosition).toCodeMirror();
>             callback({startPosition, endPosition});
>-        }
>+        };
> 
>         script.requestScriptSyntaxTree((syntaxTree) => {
>             // Convert to the position within the inline script before querying the AST.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>index 16512f6293c..fa0acdd9801 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>@@ -396,7 +396,7 @@ WI.SpreadsheetTextField = class SpreadsheetTextField
>         let selection = window.getSelection();
> 
>         let isHidden = (clientRect) => {
>-            return clientRect.x === 0 && clientRect.y === 0
>+            return clientRect.x === 0 && clientRect.y === 0;
>         };
> 
>         if (selection.rangeCount) {
>diff --git a/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterUtilities.js b/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterUtilities.js
>index 8a8946ca4e2..4b281289b52 100644
>--- a/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterUtilities.js
>+++ b/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterUtilities.js
>@@ -42,7 +42,7 @@ Object.defineProperty(String.prototype, "lineEndings",
>         let match = pattern.exec(this);
>         while (match) {
>             lineEndings.push(match.index);
>-            match = pattern.exec(this)
>+            match = pattern.exec(this);
>         }
> 
>         lineEndings.push(this.length);

Flags:

mattbaker: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188824: 347715