Attachment 347708 Details for Bug 188821 – Patch

[patch] Patch

bug-188821-20180821151452.patch (text/plain), 4.98 KB, created by Alex Christensen on 2018-08-21 15:14:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-21 15:14:53 PDT

Size: 4.98 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 235139)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-21  Alex Christensen  <achristensen@webkit.org>
>+
>+        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
>+        https://bugs.webkit.org/show_bug.cgi?id=188821
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.
>+
>+        * UIProcess/API/C/WKPageRenderingProgressEvents.h:
>+        * UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
>+        (pageRenderingProgressEvents):
>+
> 2018-08-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove unused shouldKeepCurrentBackForwardListItemInList check
>Index: Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h	(revision 235138)
>+++ Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h	(working copy)
>@@ -36,7 +36,9 @@ enum {
>     WKPageRenderingProgressEventFirstLayout = 1 << 0,
>     WKPageRenderingProgressEventFirstVisuallyNonEmptyLayout = 1 << 1,
>     WKPageRenderingProgressEventFirstPaintWithSignificantArea = 1 << 2,
>-    WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3
>+    WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3,
>+    WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering = 1 << 4,
>+    WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering = 1 << 5,
> };
> typedef uint32_t WKPageRenderingProgressEvents;
> 
>Index: Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h	(revision 235138)
>+++ Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h	(working copy)
>@@ -43,5 +43,11 @@ static inline WKPageRenderingProgressEve
>     if (milestones & WebCore::ReachedSessionRestorationRenderTreeSizeThreshold)
>         events |= WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold;
>     
>+    if (milestones & WebCore::DidFirstLayoutAfterSuppressedIncrementalRendering)
>+        events |= WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering;
>+
>+    if (milestones & WebCore::DidFirstPaintAfterSuppressedIncrementalRendering)
>+        events |= WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering;
>+
>     return events;
> }
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 235142)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-08-21  Alex Christensen  <achristensen@webkit.org>
>+
>+        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
>+        https://bugs.webkit.org/show_bug.cgi?id=188821
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
>+        (TestWebKitAPI::didLayout):
>+        (TestWebKitAPI::TEST):
>+
> 2018-08-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Translate WebKit.LimitTitleSize API test into ObjC
>Index: Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp
>===================================================================
>--- Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp	(revision 235138)
>+++ Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp	(working copy)
>@@ -44,7 +44,7 @@ static const unsigned pageLength = 100;
> static const unsigned pageGap = 100;
> static const unsigned expectedPageCount = 20;
> 
>-static void didLayout(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef, const void* clientInfo)
>+static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
> {
>     if (milestones & kWKDidFirstLayoutAfterSuppressedIncrementalRendering) {
>         PlatformWebView* webView = (PlatformWebView*)clientInfo;
>@@ -64,14 +64,14 @@ TEST(WebKit, ResizeReversePaginatedWebVi
>     WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
>     PlatformWebView webView(context.get());
> 
>-    WKPageLoaderClientV3 loaderClient;
>+    WKPageNavigationClientV3 loaderClient;
>     memset(&loaderClient, 0, sizeof(loaderClient));
> 
>     loaderClient.base.version = 3;
>     loaderClient.base.clientInfo = &webView;
>-    loaderClient.didLayout = didLayout;
>+    loaderClient.renderingProgressDidChange = didLayout;
> 
>-    WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
>+    WKPageSetPageNavigationClient(webView.page(), &loaderClient.base);
> 
>     WKPageListenForLayoutMilestones(webView.page(), kWKDidFirstLayoutAfterSuppressedIncrementalRendering);
>

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188821: 347708