Attachment 347705 Details for Bug 188783 – Patch

[patch] Patch

bug-188783-20180821145647.patch (text/plain), 2.07 KB, created by John Wilander on 2018-08-21 14:56:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Wilander

Created: 2018-08-21 14:56:48 PDT

Size: 2.07 KB

patch

obsolete

>Subversion Revision: 235141
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 70508d3187daa3c7f703fc38c39af554e3fd8fe8..3ec4d7ed3a09a3274543da0e055916c17a283002 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-21  John Wilander  <wilander@apple.com>
>+
>+        Storage Access API: The call to ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal() should send eTLD+1s, not full host names
>+        https://bugs.webkit.org/show_bug.cgi?id=188783
>+        <rdar://problem/43559215>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ResourceLoadStatisticsMemoryStore.cpp:
>+        (WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccess):
>+            Now sends the eTLD+1 for the top frame and sub frame.
>+
> 2018-08-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove unused shouldKeepCurrentBackForwardListItemInList check
>diff --git a/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp b/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp
>index 64f9db7e332f7fc5ad3f7e0f11e1e74eedac6126..7f45c769a4ac909b686249feb7bb8a53a6ce744a 100644
>--- a/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp
>+++ b/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp
>@@ -474,7 +474,7 @@ void ResourceLoadStatisticsMemoryStore::grantStorageAccess(String&& subFrameHost
>         ASSERT(subFrameStatistic.hadUserInteraction);
>         subFrameStatistic.storageAccessUnderTopFrameOrigins.add(topFramePrimaryDomain);
>     }
>-    grantStorageAccessInternal(WTFMove(subFrameHost), WTFMove(topFrameHost), frameID, pageID, userWasPromptedNow, WTFMove(completionHandler));
>+    grantStorageAccessInternal(WTFMove(subFramePrimaryDomain), WTFMove(topFramePrimaryDomain), frameID, pageID, userWasPromptedNow, WTFMove(completionHandler));
> }
> 
> void ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal(String&& subFramePrimaryDomain, String&& topFramePrimaryDomain, std::optional<uint64_t> frameID, uint64_t pageID, bool userWasPromptedNowOrEarlier, CompletionHandler<void(bool)>&& callback)

Actions: View | Formatted Diff | Diff

Attachments on bug 188783: 347705