Attachment 347695 Details for Bug 188815 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

search-focus-1.patch (text/plain), 2.16 KB, created by Joseph Pecoraro on 2018-08-21 14:26:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-08-21 14:26:50 PDT

Size: 2.16 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 7e7c195fbb4..97038dbf32f 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: âG does not while find banner is focused
>+        https://bugs.webkit.org/show_bug.cgi?id=188815
>+        <rdar://problem/43577158>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Main.js:
>+        Allow an <input> element to be the current focus element, which is what will
>+        our global KeyboardShortcut handlers will interact with. Also make sure
>+        that showing the find banner for the first time still focuses it.
>+
> 2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         JSContext Inspector: Scripts not showing up in Resources tab
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index 5ec21b8b319..cd2e8a526e7 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -1307,11 +1307,14 @@ WI._focusChanged = function(event)
>     // The selection change should not apply to text fields and text areas either.
> 
>     if (WI.isEventTargetAnEditableField(event)) {
>-        // Still update the currentFocusElement if inside of a CodeMirror editor.
>-        var codeMirrorEditorElement = event.target.enclosingNodeOrSelfWithClass("CodeMirror");
>+        // Still update the currentFocusElement if inside of a CodeMirror editor or an input element.
>+        let codeMirrorEditorElement = event.target.enclosingNodeOrSelfWithClass("CodeMirror");
>         if (codeMirrorEditorElement && codeMirrorEditorElement !== this.currentFocusElement) {
>             this.previousFocusElement = this.currentFocusElement;
>             this.currentFocusElement = codeMirrorEditorElement;
>+        } else if (event.target.tagName === "INPUT") {
>+            this.previousFocusElement = this.currentFocusElement;
>+            this.currentFocusElement = event.target;
>         }
> 
>         // Due to the change in WI.isEventTargetAnEditableField (r196271), this return

Actions: View | Formatted Diff | Diff

Attachments on bug 188815: 347695 | 347719