Attachment 347689 Details for Bug 188814 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

jscontext-scripts-1.patch (text/plain), 1.99 KB, created by Joseph Pecoraro on 2018-08-21 14:05:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-08-21 14:05:52 PDT

Size: 1.99 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 128c74780c1..7e7c195fbb4 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        JSContext Inspector: Scripts not showing up in Resources tab
>+        https://bugs.webkit.org/show_bug.cgi?id=188814
>+        <rdar://problem/43576117>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ResourceSidebarPanel.js:
>+        (WI.ResourceSidebarPanel.prototype._addScript):
>+        This path shouldn't apply to JSContext inspection which will
>+        never have a pageTarget and but doesn't have a mainResource.
>+
> 2018-08-21  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Rulers.svg is missing
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>index 34c260411c3..5424eefab65 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
>@@ -311,11 +311,13 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSideba
>             return;
> 
>         // Target main resource.
>-        if (script.target !== WI.pageTarget) {
>-            if (script.isMainResource())
>-                this._addTargetWithMainResource(script.target);
>-            this.contentTreeOutline.disclosureButtons = true;
>-            return;
>+        if (WI.sharedApp.debuggableType !== WI.DebuggableType.JavaScript) {
>+            if (script.target !== WI.pageTarget) {
>+                if (script.isMainResource())
>+                    this._addTargetWithMainResource(script.target);
>+                this.contentTreeOutline.disclosureButtons = true;
>+                return;
>+            }            
>         }
> 
>         // If the script URL matches a resource we can assume it is part of that resource and does not need added.

Actions: View | Formatted Diff | Diff

Attachments on bug 188814: 347689