Attachment 347686 Details for Bug 188811 – Patch

[patch] Patch

bug-188811-20180821134609.patch (text/plain), 1.66 KB, created by Ross Kirsling on 2018-08-21 13:46:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-08-21 13:46:09 PDT

Size: 1.66 KB

patch

obsolete

>Subversion Revision: 235127
>diff --git a/Source/cmake/OptionsMSVC.cmake b/Source/cmake/OptionsMSVC.cmake
>index 9f9e34eac287529741ec6673917f6bd50807c916..ee9fb98da23948f0d4bc35a9df3faaa65feb3ce4 100644
>--- a/Source/cmake/OptionsMSVC.cmake
>+++ b/Source/cmake/OptionsMSVC.cmake
>@@ -26,9 +26,6 @@ if (NOT COMPILER_IS_CLANG_CL)
>     add_definitions(-D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1)
> endif ()
> 
>-# Turn off certain link features
>-add_compile_options(/Gy- /openmp- /GF-)
>-
> # Enable C++17
> # https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version
> add_compile_options(/std:c++17)
>@@ -44,8 +41,6 @@ if (${CMAKE_BUILD_TYPE} MATCHES "Debug")
>     #add_compile_options(/Bv)
>     #set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /VERBOSE /VERBOSE:INCR /TIME")
>     #set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /VERBOSE /VERBOSE:INCR /TIME")
>-elseif (${CMAKE_BUILD_TYPE} MATCHES "Release")
>-    add_compile_options(/Oy-)
> endif ()
> 
> if (NOT ${CMAKE_GENERATOR} MATCHES "Ninja")
>diff --git a/ChangeLog b/ChangeLog
>index 15dbf0afc9aa3d072cbabe77bc253afe338ee88a..6d3a08bc7cc054353cf9a5da75808a1cf568ef86 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-21  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        [MSVC] Stop disabling /O2 features.
>+        https://bugs.webkit.org/show_bug.cgi?id=188811
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/cmake/OptionsMSVC.cmake:
>+        Don't disable /GF (string pooling), /Gy (function-level linking), or /Oy (frame pointer omission).
>+
> 2018-08-21  Adrian Perez de Castro  <aperez@igalia.com>
> 
>         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.91 release.

Actions: View | Formatted Diff | Diff

Attachments on bug 188811: 347686 | 347793 | 347838