WebKit Bugzilla
Attachment 347671 Details for
Bug 188802
: Fetch: Stop checking Request.integrity's value in no-cors mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188802-20180821211846.patch (text/plain), 3.50 KB, created by
Rob Buis
on 2018-08-21 12:18:47 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Rob Buis
Created:
2018-08-21 12:18:47 PDT
Size:
3.50 KB
patch
obsolete
>Subversion Revision: 235090 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 39fa429adf4e06361a0d19b5bbd907ac70bf5d27..c671c4a7c6fa8432aba20f6953db2eacd9ddbad3 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,19 @@ >+2018-08-21 Rob Buis <rbuis@igalia.com> >+ >+ Fetch: Stop checking Request.integrity's value in no-cors mode >+ https://bugs.webkit.org/show_bug.cgi?id=188802 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Remove this check since it was removed from the spec. >+ >+ Behavior matches Chrome and Firefox. >+ >+ Test: http/tests/subresource-integrity/sri-fetch.js: >+ >+ * Modules/fetch/FetchRequest.cpp: >+ (WebCore::FetchRequest::initializeOptions): >+ > 2018-08-20 Jeremy Jones <jeremyj@apple.com> > > UIWebView crashes while attempting to play youtube video on phone >diff --git a/Source/WebCore/Modules/fetch/FetchRequest.cpp b/Source/WebCore/Modules/fetch/FetchRequest.cpp >index 5398aede7d2d6353db27cb5181a42f57ebda61b1..c37ac6923f320f03ae24948e7bd473aeab890bda 100644 >--- a/Source/WebCore/Modules/fetch/FetchRequest.cpp >+++ b/Source/WebCore/Modules/fetch/FetchRequest.cpp >@@ -134,8 +134,6 @@ ExceptionOr<void> FetchRequest::initializeOptions(const Init& init) > const String& method = m_request.httpMethod(); > if (method != "GET" && method != "POST" && method != "HEAD") > return Exception { TypeError, "Method must be GET, POST or HEAD in no-cors mode."_s }; >- if (!m_options.integrity.isEmpty()) >- return Exception { TypeError, "There cannot be an integrity in no-cors mode."_s }; > m_headers->setGuard(FetchHeaders::Guard::RequestNoCors); > } > >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 924066c7a4225e2ec8ae1a8dafa9dd30acc95a86..cfd66516cf6c08170a56ae55590e1f77a953ffb7 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,12 @@ >+2018-08-21 Rob Buis <rbuis@igalia.com> >+ >+ Fetch: Stop checking Request.integrity's value in no-cors mode >+ https://bugs.webkit.org/show_bug.cgi?id=188802 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * http/tests/subresource-integrity/sri-fetch.js: >+ > 2018-08-20 Justin Fan <justin_fan@apple.com> > > Update webkit-webgl-test-harness.js to provide more info on failing and partially passing tests >diff --git a/LayoutTests/http/tests/subresource-integrity/sri-fetch.js b/LayoutTests/http/tests/subresource-integrity/sri-fetch.js >index db80eda5548a819adb77449492fcce3a70f9604d..c7f98d044c907cfa23610f60a75da14538499336 100644 >--- a/LayoutTests/http/tests/subresource-integrity/sri-fetch.js >+++ b/LayoutTests/http/tests/subresource-integrity/sri-fetch.js >@@ -59,7 +59,7 @@ integrity("Credential CORS invalid integrity", crossorigin_creds_resource, { 'in > integrity("Ineligible CORS empty integrity", crossorigin_ineligible_resource, { 'integrity': "" }, new TypeError()); > integrity("Ineligible CORS SHA-512 integrity", crossorigin_ineligible_resource, { 'integrity': topSha512 }, new TypeError()); > integrity("Ineligible CORS invalid integrity", crossorigin_ineligible_resource, { 'integrity': invalidSha512 }, new TypeError()); >-integrity("SHA-256 integrity with 'no-cors' mode", resource, { 'integrity': topSha256, 'mode': 'no-cors' }, new TypeError()); >+integrity("SHA-256 integrity with 'no-cors' mode", resource, { 'integrity': topSha256, 'mode': 'no-cors' }); > integrity("Resource with zero length body", empty_resource, { 'integrity': "47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=" }); > > done();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188802
:
347671
|
347778